Bug 23294

Summary: add Android platform-specific files to WebCore/editing
Product: WebKit Reporter: Feng Qian <feng>
Component: WebCore Misc.Assignee: Feng Qian <feng>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch v1
none
patch v2
none
patch v3
none
patch v4 darin: review+

Feng Qian
Reported 2009-01-13 09:35:49 PST
Part of upstreaming Android port. Files do not confirm to WebKit standard yet, create this bug as a placeholder, and ask for code review when files are ready.
Attachments
patch v1 (2.69 KB, patch)
2009-01-13 09:45 PST, Feng Qian 		no flags
DetailsFormatted DiffDiff
patch v2 (5.15 KB, patch)
2009-01-13 17:29 PST, Feng Qian 		no flags
DetailsFormatted DiffDiff
patch v3 (2.50 KB, patch)
2009-01-13 17:30 PST, Feng Qian 		no flags
DetailsFormatted DiffDiff
patch v4 (2.50 KB, patch)
2009-01-13 17:33 PST, Feng Qian 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Feng Qian
Comment 1 2009-01-13 09:45:01 PST
Created attachment 26670 [details] patch v1
Feng Qian
Comment 2 2009-01-13 16:31:35 PST
Comment on attachment 26670 [details] patch v1 mrowe, do you mind take a look at this file?
Darin Adler
Comment 3 2009-01-13 16:59:53 PST
Comment on attachment 26670 [details] patch v1 > +#include "ClipboardAndroid.h" > +#include "Document.h" > +#include "Element.h" > +#include "htmlediting.h" > +#include "NotImplemented.h" > +#include "TextIterator.h" > +#include "visible_units.h" I don't think we need any of these includes except for ClipboardAndroid.h. r=me
Feng Qian
Comment 4 2009-01-13 17:29:15 PST
Created attachment 26696 [details] patch v2 Removed unneeded header file includes. Thanks for quick review!
Feng Qian
Comment 5 2009-01-13 17:30:50 PST
Created attachment 26697 [details] patch v3 v3, sorry, v2 includes changes of another bug by accident.
Feng Qian
Comment 6 2009-01-13 17:33:24 PST
Created attachment 26698 [details] patch v4 Remove tab in the ChangeLog. Sorry for the trouble.
Darin Adler
Comment 7 2009-01-13 17:35:41 PST
Comment on attachment 26698 [details] patch v4 r=me
Brent Fulgham
Comment 8 2009-02-04 23:28:00 PST
Committed in @r40668.
Note You need to log in before you can comment on or make changes to this bug.