Bug 232909

Summary: [iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, brad, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, philipj, sergio, webkit-bug-importer, wes
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch for landing
none
Follow up patch
ews-feeder: commit-queue-
Follow up patch
none
Follow up patch none

Description Jer Noble 2021-11-09 15:23:48 PST 
[iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]
Comment 1 Jer Noble 2021-11-09 15:24:31 PST 
<rdar://68184444>
Comment 2 Jer Noble 2021-11-09 17:25:57 PST 
Created attachment 443760 [details]
Patch
Comment 3 Jer Noble 2021-11-09 19:54:20 PST 
Created attachment 443770 [details]
Patch
Comment 4 Eric Carlson 2021-11-10 08:23:46 PST 
Comment on attachment 443770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443770&action=review

> Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:195
> +        if (proxy.gpuConnectionToWebProcess().presentingApplicationAuditToken())
> +            presentingProcesses.append(*proxy.gpuConnectionToWebProcess().presentingApplicationAuditToken());

Nit: it would be more efficient, in a Debug build at least, to put the token into a local variable
Comment 5 Jer Noble 2021-11-10 08:43:27 PST 
Created attachment 443820 [details]
Patch for landing
Comment 6 EWS 2021-11-10 08:44:10 PST 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 7 Jer Noble 2021-11-10 08:44:31 PST 
Created attachment 443821 [details]
Patch for landing
Comment 8 EWS 2021-11-10 09:32:50 PST 
Committed r285584 (244092@main): <https://commits.webkit.org/244092@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443821 [details].
Comment 9 Jer Noble 2021-11-11 09:49:50 PST 
Reopening to attach new patch.
Comment 10 Jer Noble 2021-11-11 09:49:52 PST 
Created attachment 443959 [details]
Follow up patch
Comment 11 Chris Dumez 2021-11-11 09:53:46 PST 
Comment on attachment 443959 [details]
Follow up patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443959&action=review

> Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:172
> +#if HAVE(AUDIOSESSION_PROCESSASSERTION)

You want an #else with a UNUSED_PARAM(auditTokens);
Comment 12 Jer Noble 2021-11-11 10:22:57 PST 
Created attachment 443966 [details]
Follow up patch
Comment 13 Chris Dumez 2021-11-11 10:26:00 PST 
Comment on attachment 443966 [details]
Follow up patch

r=me
Comment 14 EWS 2021-11-11 12:28:09 PST 
Committed r285646 (244147@main): <https://commits.webkit.org/244147@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443966 [details].
Comment 15 Jer Noble 2021-11-15 12:27:33 PST 
Reopening to attach new patch.
Comment 16 Jer Noble 2021-11-15 12:27:35 PST 
Created attachment 444293 [details]
Follow up patch
Comment 17 EWS 2021-11-15 14:25:24 PST 
Committed r285836 (244268@main): <https://commits.webkit.org/244268@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444293 [details].
Comment 18 Maciej Stachowiak 2022-05-12 10:53:31 PDT 
*** Bug 198277 has been marked as a duplicate of this bug. ***