Bug 232898

Summary: Add runtime flag for momentum scrolling animator
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cmarcelo, ews-watchlist, fred.wang, hi, jamesr, jonlee, luiz, simon.fraser, tonikitoo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Tim Horton 2021-11-09 11:45:10 PST 
Add runtime flag for momentum scrolling
Comment 1 Tim Horton 2021-11-09 11:46:27 PST 
Created attachment 443712 [details]
Patch
Comment 2 Tim Horton 2021-11-09 11:46:31 PST 
<rdar://problem/85211338>
Comment 3 Simon Fraser (smfr) 2021-11-09 11:48:48 PST 
Comment on attachment 443712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443712&action=review

> Source/WebCore/page/scrolling/ScrollingStateNode.h:271
> +        MomentumScrollingAnimatorEnabled            = 1LLU << 44,

Can we move this up below AsyncFrameOrOverflowScrollingEnabled (and, yeah, change all the values).
Comment 4 Tim Horton 2021-11-09 11:55:06 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 443712 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443712&action=review
> 
> > Source/WebCore/page/scrolling/ScrollingStateNode.h:271
> > +        MomentumScrollingAnimatorEnabled            = 1LLU << 44,
> 
> Can we move this up below AsyncFrameOrOverflowScrollingEnabled (and, yeah,
> change all the values).

Sure!
Comment 5 Tim Horton 2021-11-09 11:59:24 PST 
Created attachment 443714 [details]
Patch
Comment 6 Tim Horton 2021-11-09 12:12:32 PST 
Created attachment 443717 [details]
Patch
Comment 7 Tim Horton 2021-11-09 13:06:43 PST 
https://trac.webkit.org/changeset/285526/webkit