Bug 232898

Summary: Add runtime flag for momentum scrolling animator
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cmarcelo, ews-watchlist, fred.wang, hi, jamesr, jonlee, luiz, simon.fraser, tonikitoo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Tim Horton
Reported 2021-11-09 11:45:10 PST
Add runtime flag for momentum scrolling
Attachments
Patch (18.22 KB, patch)
2021-11-09 11:46 PST, Tim Horton 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (20.18 KB, patch)
2021-11-09 11:59 PST, Tim Horton 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (20.30 KB, patch)
2021-11-09 12:12 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-11-09 11:46:27 PST
Created attachment 443712 [details] Patch
Tim Horton
Comment 2 2021-11-09 11:46:31 PST
<rdar://problem/85211338>
Simon Fraser (smfr)
Comment 3 2021-11-09 11:48:48 PST
Comment on attachment 443712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443712&action=review > Source/WebCore/page/scrolling/ScrollingStateNode.h:271 > + MomentumScrollingAnimatorEnabled = 1LLU << 44, Can we move this up below AsyncFrameOrOverflowScrollingEnabled (and, yeah, change all the values).
Tim Horton
Comment 4 2021-11-09 11:55:06 PST
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 443712 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443712&action=review > > > Source/WebCore/page/scrolling/ScrollingStateNode.h:271 > > + MomentumScrollingAnimatorEnabled = 1LLU << 44, > > Can we move this up below AsyncFrameOrOverflowScrollingEnabled (and, yeah, > change all the values). Sure!
Tim Horton
Comment 5 2021-11-09 11:59:24 PST
Created attachment 443714 [details] Patch
Tim Horton
Comment 6 2021-11-09 12:12:32 PST
Created attachment 443717 [details] Patch
Tim Horton
Comment 7 2021-11-09 13:06:43 PST
https://trac.webkit.org/changeset/285526/webkit
Note You need to log in before you can comment on or make changes to this bug.