Bug 232897

Summary: Run a ScrollAnimationMomentum for the momentum phase of a scroll
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, jonlee, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
thorton: review+
Patch none

Simon Fraser (smfr)
Reported 2021-11-09 11:28:16 PST
Run a ScrollAnimationMomentum for the momentum phase of a scroll
Attachments
Patch (17.36 KB, patch)
2021-11-09 11:29 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (19.49 KB, patch)
2021-11-09 18:22 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (27.81 KB, patch)
2021-11-13 18:39 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Patch (27.80 KB, patch)
2021-11-13 21:10 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-11-09 11:29:23 PST Comment hidden (obsolete)
Radar WebKit Bug Importer
Comment 2 2021-11-09 15:36:16 PST Comment hidden (obsolete)
Simon Fraser (smfr)
Comment 3 2021-11-09 18:22:57 PST Comment hidden (obsolete)
Simon Fraser (smfr)
Comment 4 2021-11-13 18:39:47 PST
Created attachment 444160 [details] Patch
Wenson Hsieh
Comment 5 2021-11-13 20:38:20 PST
Comment on attachment 444160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444160&action=review > Source/WebCore/platform/ScrollingEffectsController.cpp:151 > + auto contrainedOffset = currentOffset.constrainedBetween(extents.minimumScrollOffset(), extents.maximumScrollOffset()); sp. "contrainedOffset"
Simon Fraser (smfr)
Comment 6 2021-11-13 21:10:07 PST
Created attachment 444164 [details] Patch
EWS
Comment 7 2021-11-13 23:37:43 PST
Committed r285787 (244231@main): <https://commits.webkit.org/244231@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444164 [details].
Note You need to log in before you can comment on or make changes to this bug.