Bug 232897 - Run a ScrollAnimationMomentum for the momentum phase of a scroll
Summary: Run a ScrollAnimationMomentum for the momentum phase of a scroll
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-09 11:28 PST by Simon Fraser (smfr)
Modified: 2021-11-13 23:37 PST (History)
11 users (show)

See Also:

Attachments
Patch (17.36 KB, patch)
2021-11-09 11:29 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (19.49 KB, patch)
2021-11-09 18:22 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (27.81 KB, patch)
2021-11-13 18:39 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Patch (27.80 KB, patch)
2021-11-13 21:10 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-11-09 11:28:16 PST 
Run a ScrollAnimationMomentum for the momentum phase of a scroll
Comment 1 Simon Fraser (smfr) 2021-11-09 11:29:23 PST Comment hidden (obsolete)
Comment 2 Radar WebKit Bug Importer 2021-11-09 15:36:16 PST Comment hidden (obsolete)
Comment 3 Simon Fraser (smfr) 2021-11-09 18:22:57 PST Comment hidden (obsolete)
Comment 4 Simon Fraser (smfr) 2021-11-13 18:39:47 PST 
Created attachment 444160 [details]
Patch
Comment 5 Wenson Hsieh 2021-11-13 20:38:20 PST 
Comment on attachment 444160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444160&action=review

> Source/WebCore/platform/ScrollingEffectsController.cpp:151
> +        auto contrainedOffset = currentOffset.constrainedBetween(extents.minimumScrollOffset(), extents.maximumScrollOffset());

sp. "contrainedOffset"
Comment 6 Simon Fraser (smfr) 2021-11-13 21:10:07 PST 
Created attachment 444164 [details]
Patch
Comment 7 EWS 2021-11-13 23:37:43 PST 
Committed r285787 (244231@main): <https://commits.webkit.org/244231@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444164 [details].