Bug 232863

Summary: Fix wrong frame count of CARingBuffer in SpeechRecognitionRemoteRealtimeMediaSource
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq] Patch none

Sihui Liu
Reported 2021-11-08 19:52:29 PST
...
Attachments
Patch (5.45 KB, patch)
2021-11-08 20:18 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (1.14 KB, patch)
2021-11-09 13:34 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2021-11-08 19:53:01 PST
<rdar://83381842>
Sihui Liu
Comment 2 2021-11-08 20:18:06 PST
Created attachment 443650 [details] Patch
youenn fablet
Comment 3 2021-11-08 23:50:27 PST
Comment on attachment 443650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443650&action=review > Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:86 > + m_description = description; Do we need to set m_description here again, since we already set it when allocating m_ringBuffer? It seems we should set m_description once and I would tend to do it in audioSamplesAvailable.
Sihui Liu
Comment 4 2021-11-09 09:06:26 PST
(In reply to youenn fablet from comment #3) > Comment on attachment 443650 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443650&action=review > > > Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:86 > > + m_description = description; > > Do we need to set m_description here again, since we already set it when > allocating m_ringBuffer? > It seems we should set m_description once and I would tend to do it in > audioSamplesAvailable. I don't understand. Do we set m_description elsewhere in SpeechRecognitionRemoteRealtimeMediaSource? Do you mean m_description in SpeechRecognitionRealtimeMediaSourceManager::Source?
Sihui Liu
Comment 5 2021-11-09 10:47:12 PST
Comment on attachment 443650 [details] Patch Land the patch as it is to fix the bug first. Let me know if you think we should set m_description in a different place, and I will follow up.
EWS
Comment 6 2021-11-09 10:53:21 PST
Committed r285509 (244032@main): <https://commits.webkit.org/244032@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443650 [details].
Sihui Liu
Comment 7 2021-11-09 13:34:37 PST
Reopening to attach new patch.
Sihui Liu
Comment 8 2021-11-09 13:34:39 PST
Created attachment 443722 [details] [fast-cq] Patch
Sihui Liu
Comment 9 2021-11-09 13:35:22 PST
Comment on attachment 443722 [details] [fast-cq] Patch Unreviewed build fix.
EWS
Comment 10 2021-11-09 13:36:56 PST
Committed r285531 (244048@main): <https://commits.webkit.org/244048@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443722 [details].
Note You need to log in before you can comment on or make changes to this bug.