Bug 232838

Summary:

Parse redirect and modify-headers actions for WKContentRuleList

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, pangle, saam, timothy, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Description Alex Christensen 2021-11-08 12:49:18 PST

Parse redirect and modify-headers actions for WKContentRuleList

Comment 1 Alex Christensen 2021-11-08 12:50:48 PST Comment hidden (obsolete)

Created attachment 443591 [details]
Patch

Comment 2 Alex Christensen 2021-11-08 14:59:42 PST

Created attachment 443613 [details]
Patch

Comment 3 Timothy Hatcher 2021-11-08 15:02:47 PST Comment hidden (obsolete)

Comment on attachment 443591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443591&action=review

> Source/WebCore/contentextensions/ContentExtensionError.cpp:97
> +                return "add-or-replace-parameters value must be an array";

"A add-or-replace-parameters value…" to match the other errors.

Comment 4 Timothy Hatcher 2021-11-08 15:04:25 PST

Comment on attachment 443613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443613&action=review

> Source/WebCore/contentextensions/ContentExtensionError.cpp:95
> +                return "add-or-replace-parameters value must be an array";

"A add-or-replace-parameters value…" to match the other errors.

Comment 5 Alex Christensen 2021-11-08 15:16:10 PST

Created attachment 443615 [details]
Patch

Comment 6 Alex Christensen 2021-11-08 16:18:31 PST

https://trac.webkit.org/changeset/285443/webkit

Comment 7 Radar WebKit Bug Importer 2021-11-08 16:19:22 PST

<rdar://problem/85178198>