| Summary: | Fix the CGEvent types used for wheel event generation from streams | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | sam, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=232794 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-11-07 20:40:41 PST
Created attachment 443524 [details]
Patch
Comment on attachment 443524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443524&action=review > Tools/ChangeLog:10 > + The set of enum values for wheel event types are confusing, and I used the wrong ones in > + r285390, so fix that. Values are all the same other than kCGMomentumScrollPhaseEnd which is > + now correct. Is the end phase being different detectable? (In reply to Sam Weinig from comment #2) > Comment on attachment 443524 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443524&action=review > > > Tools/ChangeLog:10 > > + The set of enum values for wheel event types are confusing, and I used the wrong ones in > > + r285390, so fix that. Values are all the same other than kCGMomentumScrollPhaseEnd which is > > + now correct. > > Is the end phase being different detectable? I don't think it is currently. Since this is new test infrastructure I didn't try to make a regression test for that. |