Bug 232802

Summary: Enabling "media source inline painting" by default should work when using GPU Process for media
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble, peng.liu6, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
For EWS
none
Fix minor typo none

Wenson Hsieh
Reported 2021-11-07 16:57:23 PST
.
Attachments
For EWS (9.97 KB, patch)
2021-11-07 17:06 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix minor typo (9.96 KB, patch)
2021-11-07 17:07 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-11-07 17:06:12 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-11-07 17:07:51 PST
Created attachment 443522 [details] Fix minor typo
Wenson Hsieh
Comment 3 2021-11-08 09:17:53 PST
Comment on attachment 443522 [details] Fix minor typo View in context: https://bugs.webkit.org/attachment.cgi?id=443522&action=review Thanks for the review! > Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:612 > + // FIXME: Additionally, it seems wrong to consult preferences on WebPageGroup rather than WebPreferences corresponding to each page. (FYI): I'm working on a followup patch here that will address this FIXME, and make it possible to use the experimental features menu to toggle mediaSourceInlinePaintingEnabled (as well as opusDecoderEnabled, vorbisDecoderEnabled, etc.) when using GPUP for media.
EWS
Comment 4 2021-11-08 09:58:05 PST
Committed r285410 (243967@main): <https://commits.webkit.org/243967@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443522 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-08 09:59:20 PST
<rdar://problem/85160450>
Note You need to log in before you can comment on or make changes to this bug.