| Summary: | Enabling "media source inline painting" by default should work when using GPU Process for media | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | Media | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric.carlson, jer.noble, peng.liu6, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2021-11-07 16:57:23 PST
Created attachment 443521 [details]
For EWS
Created attachment 443522 [details]
Fix minor typo
Comment on attachment 443522 [details] Fix minor typo View in context: https://bugs.webkit.org/attachment.cgi?id=443522&action=review Thanks for the review! > Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:612 > + // FIXME: Additionally, it seems wrong to consult preferences on WebPageGroup rather than WebPreferences corresponding to each page. (FYI): I'm working on a followup patch here that will address this FIXME, and make it possible to use the experimental features menu to toggle mediaSourceInlinePaintingEnabled (as well as opusDecoderEnabled, vorbisDecoderEnabled, etc.) when using GPUP for media. Committed r285410 (243967@main): <https://commits.webkit.org/243967@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443522 [details]. |