Bug 23280

Summary: Move defaultUnitsPerEm to SimpleFontData
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 submitted for review none

Description Dimitri Glazkov (Google) 2009-01-12 16:04:18 PST 
Bug 22936 introduced defaultUnitsPerEm constant to SVGFontFaceElement.h. The trouble is, this constant was used in SimpleFontData, which made non-SVG-enabled builds break.
Comment 1 Dimitri Glazkov (Google) 2009-01-12 16:31:55 PST 
Created attachment 26655 [details]
v1 submitted for review

 WebCore/ChangeLog                          |   11 +++++++++++
 WebCore/platform/graphics/SimpleFontData.h |    2 ++
 WebCore/svg/SVGFontFaceElement.cpp         |    1 +
 3 files changed, 14 insertions(+), 0 deletions(-)
Comment 2 Mark Rowe (bdash) 2009-01-12 17:05:05 PST 
Is this still needed after <http://trac.webkit.org/changeset/39843>?
Comment 3 Dimitri Glazkov (Google) 2009-01-12 20:17:23 PST 
Gah! Changeset collision. Sparks fly!

Ok, I think his solution is fine, too. Closing this one.
Comment 4 Eric Seidel (no email) 2009-01-13 14:24:31 PST 
Comment on attachment 26655 [details]
v1 submitted for review

clearing review flag.  silly bugzilla.