| Summary: | [WebXR] three.js demos don't work | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, mmaxfield, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 232878 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Dean Jackson
2021-11-07 10:46:10 PST
Created attachment 443514 [details]
Patch
Created attachment 443588 [details]
Patch
Comment on attachment 443588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443588&action=review > Source/WebCore/ChangeLog:26 > + What’s the long term strategy to test this stuff? I’m willing to review this one patch without a test because AIUI there is no testing infrastructure yet, but there should at least be a plan about how we’re going to add tests on the future. Committed r285436 (243992@main): <https://commits.webkit.org/243992@main> (In reply to Myles C. Maxfield from comment #4) > Comment on attachment 443588 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443588&action=review > > > Source/WebCore/ChangeLog:26 > > + > > What’s the long term strategy to test this stuff? I’m willing to review this > one patch without a test because AIUI there is no testing infrastructure > yet, but there should at least be a plan about how we’re going to add tests > on the future. Yes. This worries me as well. I think we'll be able to get our testing framework to at least write out some frames that we could use for comparison. Re-opened since this is blocked by bug 232878 Created attachment 443731 [details]
WPE build test
Committed r285544 (244058@main): <https://commits.webkit.org/244058@main> |