Bug 232798

Summary: [WebXR] three.js demos don't work
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232878    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
mmaxfield: review+, ews-feeder: commit-queue-
WPE build test none

Dean Jackson
Reported 2021-11-07 10:46:10 PST
[WebXR] three.js demos don't work
Attachments
Patch (7.70 KB, patch)
2021-11-07 10:55 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (7.70 KB, patch)
2021-11-08 12:33 PST, Dean Jackson 		mmaxfield: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WPE build test (7.78 KB, patch)
2021-11-09 14:28 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2021-11-07 10:55:45 PST
Created attachment 443514 [details] Patch
Dean Jackson
Comment 2 2021-11-07 10:58:02 PST
rdar://83559881
Dean Jackson
Comment 3 2021-11-08 12:33:18 PST
Created attachment 443588 [details] Patch
Myles C. Maxfield
Comment 4 2021-11-08 12:56:58 PST
Comment on attachment 443588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443588&action=review > Source/WebCore/ChangeLog:26 > + What’s the long term strategy to test this stuff? I’m willing to review this one patch without a test because AIUI there is no testing infrastructure yet, but there should at least be a plan about how we’re going to add tests on the future.
Dean Jackson
Comment 5 2021-11-08 15:18:20 PST
Committed r285436 (243992@main): <https://commits.webkit.org/243992@main>
Dean Jackson
Comment 6 2021-11-08 15:19:49 PST
(In reply to Myles C. Maxfield from comment #4) > Comment on attachment 443588 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443588&action=review > > > Source/WebCore/ChangeLog:26 > > + > > What’s the long term strategy to test this stuff? I’m willing to review this > one patch without a test because AIUI there is no testing infrastructure > yet, but there should at least be a plan about how we’re going to add tests > on the future. Yes. This worries me as well. I think we'll be able to get our testing framework to at least write out some frames that we could use for comparison.
WebKit Commit Bot
Comment 7 2021-11-09 06:19:11 PST
Re-opened since this is blocked by bug 232878
Dean Jackson
Comment 8 2021-11-09 14:28:37 PST
Created attachment 443731 [details] WPE build test
Dean Jackson
Comment 9 2021-11-09 16:50:28 PST
Committed r285544 (244058@main): <https://commits.webkit.org/244058@main>
Note You need to log in before you can comment on or make changes to this bug.