Bug 232798 - [WebXR] three.js demos don't work
Summary: [WebXR] three.js demos don't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on: 232878
Blocks:
  Show dependency tree / graph
 
Reported: 2021-11-07 10:46 PST by Dean Jackson
Modified: 2021-11-09 16:50 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.70 KB, patch)
2021-11-07 10:55 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (7.70 KB, patch)
2021-11-08 12:33 PST, Dean Jackson 		mmaxfield: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WPE build test (7.78 KB, patch)
2021-11-09 14:28 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-11-07 10:46:10 PST 
[WebXR] three.js demos don't work
Comment 1 Dean Jackson 2021-11-07 10:55:45 PST 
Created attachment 443514 [details]
Patch
Comment 2 Dean Jackson 2021-11-07 10:58:02 PST 
rdar://83559881
Comment 3 Dean Jackson 2021-11-08 12:33:18 PST 
Created attachment 443588 [details]
Patch
Comment 4 Myles C. Maxfield 2021-11-08 12:56:58 PST 
Comment on attachment 443588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443588&action=review

> Source/WebCore/ChangeLog:26
> +

What’s the long term strategy to test this stuff? I’m willing to review this one patch without a test because AIUI there is no testing infrastructure yet, but there should at least be a plan about how we’re going to add tests on the future.
Comment 5 Dean Jackson 2021-11-08 15:18:20 PST 
Committed r285436 (243992@main): <https://commits.webkit.org/243992@main>
Comment 6 Dean Jackson 2021-11-08 15:19:49 PST 
(In reply to Myles C. Maxfield from comment #4)
> Comment on attachment 443588 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443588&action=review
> 
> > Source/WebCore/ChangeLog:26
> > +
> 
> What’s the long term strategy to test this stuff? I’m willing to review this
> one patch without a test because AIUI there is no testing infrastructure
> yet, but there should at least be a plan about how we’re going to add tests
> on the future.

Yes. This worries me as well. I think we'll be able to get our testing framework to at least write out some frames that we could use for comparison.
Comment 7 WebKit Commit Bot 2021-11-09 06:19:11 PST 
Re-opened since this is blocked by bug 232878
Comment 8 Dean Jackson 2021-11-09 14:28:37 PST 
Created attachment 443731 [details]
WPE build test
Comment 9 Dean Jackson 2021-11-09 16:50:28 PST 
Committed r285544 (244058@main): <https://commits.webkit.org/244058@main>