Bug 232797

Summary: Use narrower types for style scope ordinal and cascade layer priority
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232827
Bug Depends on: 232828, 232930    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Antti Koivisto
Reported 2021-11-07 01:22:50 PST
Shrink some critical style related data structures.
Attachments
Patch (6.09 KB, patch)
2021-11-07 01:30 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (8.56 KB, patch)
2021-11-07 07:38 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (8.55 KB, patch)
2021-11-07 07:41 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.54 KB, patch)
2021-11-10 23:07 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.53 KB, patch)
2021-11-10 23:14 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-11-07 01:30:05 PST
Created attachment 443502 [details] Patch
Antti Koivisto
Comment 2 2021-11-07 07:38:48 PST
Created attachment 443508 [details] Patch
Antti Koivisto
Comment 3 2021-11-07 07:41:56 PST
Created attachment 443509 [details] Patch
EWS
Comment 4 2021-11-07 10:58:19 PST
Committed r285392 (243949@main): <https://commits.webkit.org/243949@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443509 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-07 10:59:20 PST
<rdar://problem/85126679>
WebKit Commit Bot
Comment 6 2021-11-08 11:42:14 PST
Re-opened since this is blocked by bug 232828
Ryan Haddad
Comment 7 2021-11-08 11:48:12 PST
This change appears to have caused a layout test regression, would be good to investigate before re-landing: https://bugs.webkit.org/show_bug.cgi?id=232827
Antti Koivisto
Comment 8 2021-11-10 23:07:30 PST
Created attachment 443915 [details] Patch for landing
EWS
Comment 9 2021-11-10 23:08:31 PST
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Antti Koivisto
Comment 10 2021-11-10 23:14:08 PST
Created attachment 443916 [details] Patch for landing
EWS
Comment 11 2021-11-11 00:21:58 PST
Committed r285622 (244123@main): <https://commits.webkit.org/244123@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443916 [details].
Note You need to log in before you can comment on or make changes to this bug.