| Summary: | restore canvas WPTs removed in bug 232449 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||||
| Component: | Tools / Tests | Assignee: | Cameron McCormack (:heycam) <heycam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, clopez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, rniwa, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 232449 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Cameron McCormack (:heycam)
2021-11-06 22:53:32 PDT
Created attachment 443500 [details]
Patch
Comment on attachment 443500 [details]
Patch
rs=me
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 443519 [details]
[fast-cq] Patch
Committed r285394 (243951@main): <https://commits.webkit.org/243951@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443519 [details]. (In reply to Cameron McCormack (:heycam) from comment #0) > I think the WPT updating script sometimes has trouble with directories named > "manual" -- maybe it considers it a directory of manual tests, which by > default are not imported? The WPT updating in bug 232449 inadvertently > removed a bunch of canvas tests under a "manual" directory, which aren't > manual tests. Oh, it wasn’t the importer, it was me. I saw a folder named manual so I removed it since we don’t care about manual tests. Sorry if this was a mistake. Maybe this folder should be named differently if it doesn’t contain manual tests. |