Bug 232795

Summary: restore canvas WPTs removed in bug 232449
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Tools / TestsAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, clopez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, rniwa, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232449    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
[fast-cq] Patch none

Cameron McCormack (:heycam)
Reported 2021-11-06 22:53:32 PDT
I think the WPT updating script sometimes has trouble with directories named "manual" -- maybe it considers it a directory of manual tests, which by default are not imported? The WPT updating in bug 232449 inadvertently removed a bunch of canvas tests under a "manual" directory, which aren't manual tests.
Attachments
Patch (1.09 MB, patch)
2021-11-06 22:56 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (1.09 MB, patch)
2021-11-07 13:02 PST, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-06 22:54:02 PDT
<rdar://problem/85108161>
Cameron McCormack (:heycam)
Comment 2 2021-11-06 22:56:29 PDT
Created attachment 443500 [details] Patch
Ryosuke Niwa
Comment 3 2021-11-06 23:46:01 PDT
Comment on attachment 443500 [details] Patch rs=me
EWS
Comment 4 2021-11-07 00:45:19 PDT
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Cameron McCormack (:heycam)
Comment 5 2021-11-07 13:02:53 PST
Created attachment 443519 [details] [fast-cq] Patch
EWS
Comment 6 2021-11-07 13:13:35 PST
Committed r285394 (243951@main): <https://commits.webkit.org/243951@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443519 [details].
Chris Dumez
Comment 7 2021-11-07 15:07:57 PST
(In reply to Cameron McCormack (:heycam) from comment #0) > I think the WPT updating script sometimes has trouble with directories named > "manual" -- maybe it considers it a directory of manual tests, which by > default are not imported? The WPT updating in bug 232449 inadvertently > removed a bunch of canvas tests under a "manual" directory, which aren't > manual tests. Oh, it wasn’t the importer, it was me. I saw a folder named manual so I removed it since we don’t care about manual tests. Sorry if this was a mistake. Maybe this folder should be named differently if it doesn’t contain manual tests.
Note You need to log in before you can comment on or make changes to this bug.