Bug 232772 – [LFC][IFC] Process all replacement, control and opaque inline items.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

generate bidi level for all the inline items.

[alan]

Created attachment 443451 [details]
Patch

[alan]

Created attachment 443476 [details]
Patch

[Antti Koivisto]

Comment on attachment 443476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443476&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:147
> +    size_t inlineTextBoxOffset = 0;
> +    for (size_t index = 0; index < inlineItems.size(); ++index) {

Could we reserverInitialCapacity() for InlineItemOffsetList and then use uncheckedAppend?

[alan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 443476 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443476&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:147
> > +    size_t inlineTextBoxOffset = 0;
> > +    for (size_t index = 0; index < inlineItems.size(); ++index) {
> 
> Could we reserverInitialCapacity() for InlineItemOffsetList and then use
> uncheckedAppend?
Good point! Will do.

[alan]

Created attachment 443487 [details]
Patch

[EWS]

Committed r285374 (243931@main): <https://commits.webkit.org/243931@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443487 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85103505>