Bug 232750

Summary: Remove separate classes for CSS wide keywords (initial/inherit/unset/revert)
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, macpherson, menard, mifenton, ntim, pdr, sabouhallawa, sam, schenney, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 224816    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Antti Koivisto 2021-11-05 03:25:31 PDT 
They can all be handled by CSSPrimitiveValue.
Comment 1 Antti Koivisto 2021-11-05 03:27:45 PDT 
Created attachment 443385 [details]
Patch
Comment 2 Antti Koivisto 2021-11-05 09:07:37 PDT 
Created attachment 443399 [details]
Patch
Comment 3 Antti Koivisto 2021-11-05 09:12:39 PDT 
Created attachment 443400 [details]
Patch
Comment 4 Antti Koivisto 2021-11-05 10:32:56 PDT 
Created attachment 443415 [details]
Patch
Comment 5 Antti Koivisto 2021-11-05 10:37:26 PDT 
Created attachment 443416 [details]
Patch
Comment 6 Antti Koivisto 2021-11-06 05:36:51 PDT 
Created attachment 443483 [details]
Patch
Comment 7 Antti Koivisto 2021-11-06 07:04:50 PDT 
Created attachment 443484 [details]
Patch
Comment 8 Antti Koivisto 2021-11-06 07:22:51 PDT 
Created attachment 443485 [details]
Patch
Comment 9 Tim Nguyen (:ntim) 2021-11-06 09:08:31 PDT 
*** Bug 224815 has been marked as a duplicate of this bug. ***
Comment 10 Sam Weinig 2021-11-06 09:44:53 PDT 
Comment on attachment 443485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443485&action=review

> Source/WebCore/bindings/js/JSDeprecatedCSSOMValueCustom.cpp:54
> +    if (value->isPrimitiveValue() && !downcast<DeprecatedCSSOMPrimitiveValue>(value.get()).isCSSWideKeyword())

This could use a comment and/or a dedicated predicate that states that the value should be exposed as something else.
Comment 11 Antti Koivisto 2021-11-06 11:39:15 PDT 
Created attachment 443489 [details]
Patch for landing
Comment 12 EWS 2021-11-06 12:21:06 PDT 
Committed r285373 (243930@main): <https://commits.webkit.org/243930@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443489 [details].
Comment 13 Radar WebKit Bug Importer 2021-11-06 12:22:20 PDT 
<rdar://problem/85103336>