Bug 232740

Summary: Infinite loop in SourceBufferParserWebM::SegmentReader::Read
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jean-yves.avenard, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 234496    
Attachments:
Description Flags
Patch
none
Patch for landing
ews-feeder: commit-queue-
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Jer Noble
Reported 2021-11-04 17:44:23 PDT
Infinite loop in SourceBufferParserWebM::SegmentReader::Read
Attachments
Patch (8.62 KB, patch)
2021-11-04 17:56 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.64 KB, patch)
2021-11-05 09:19 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (9.05 KB, patch)
2021-11-05 09:40 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (10.27 KB, patch)
2021-11-05 10:20 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-11-04 17:54:06 PDT
<rdar://83573873>
Jer Noble
Comment 2 2021-11-04 17:56:04 PDT
Created attachment 443364 [details] Patch
Eric Carlson
Comment 3 2021-11-05 09:12:03 PDT
Comment on attachment 443364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443364&action=review r=me once the bots can deal with it > Source/WebCore/ChangeLog:13 > + MTPluginByteSourceRead() call is failing and returning an error. When an error occurrs, the s/occurrs/occurs/ > Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:313 > + if (!readResult) I thinks "!readResult.has_value()", like you use above, is clearer. > Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:406 > + if (!readResult) Ditto
Jer Noble
Comment 4 2021-11-05 09:19:18 PDT
Created attachment 443402 [details] Patch for landing
Jer Noble
Comment 5 2021-11-05 09:40:42 PDT
Created attachment 443407 [details] Patch for landing
Jer Noble
Comment 6 2021-11-05 10:20:35 PDT
Created attachment 443413 [details] Patch for landing
EWS
Comment 7 2021-11-08 08:19:36 PST
Committed r285402 (243959@main): <https://commits.webkit.org/243959@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443413 [details].
Note You need to log in before you can comment on or make changes to this bug.