| Summary: | Infinite loop in SourceBufferParserWebM::SegmentReader::Read | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||
| Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jean-yves.avenard, peng.liu6, philipj, sergio, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 234496 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jer Noble
2021-11-04 17:44:23 PDT
Created attachment 443364 [details]
Patch
Comment on attachment 443364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443364&action=review r=me once the bots can deal with it > Source/WebCore/ChangeLog:13 > + MTPluginByteSourceRead() call is failing and returning an error. When an error occurrs, the s/occurrs/occurs/ > Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:313 > + if (!readResult) I thinks "!readResult.has_value()", like you use above, is clearer. > Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:406 > + if (!readResult) Ditto Created attachment 443402 [details]
Patch for landing
Created attachment 443407 [details]
Patch for landing
Created attachment 443413 [details]
Patch for landing
Committed r285402 (243959@main): <https://commits.webkit.org/243959@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443413 [details]. |