Bug 232694

Summary: [fast-cq] Require MediaSessionCoordinator enabled to enable MediaSession PlayList API
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, zdobersek
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232687
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Diego Pino
Reported 2021-11-03 21:07:08 PDT
Require MediaSession enabled to enable MediaSession PlayList API
Attachments
Patch (1.37 KB, patch)
2021-11-03 21:07 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2021-11-03 21:14 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (4.15 KB, patch)
2021-11-03 23:53 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2021-11-03 21:07:35 PDT
Created attachment 443269 [details] Patch
Diego Pino
Comment 2 2021-11-03 21:14:25 PDT
Created attachment 443270 [details] Patch
Diego Pino
Comment 3 2021-11-03 21:22:29 PDT
r285241 enabled MediaSession PlayList API on the condition `WebKit::defaultMediaSessionCoordinatorEnabled()`, but definition of that function is guarded by ENABLE(MEDIA_SESSION_COORDINATOR) (https://webkit-search.igalia.com/webkit/source/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp#333). The flag is disabled in WebKitGTK/WPE (https://webkit-search.igalia.com/webkit/source/Source/cmake/WebKitFeatures.cmake#171), which caused r285241 to break compilation in WebKitGTK/WPE. https://build.webkit.org/#/builders/41/builds/7221 ``` /app/webkit/WebKitBuild/Release/DerivedSources/WebKit/WebPreferencesDefinitions.h:621:63: error: ‘defaultMediaSessionCoordinatorEnabled’ is not a member of ‘WebKit’ 621 | #define DEFAULT_VALUE_FOR_MediaSessionPlaylistEnabled WebKit::defaultMediaSessionCoordinatorEnabled() | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```
Diego Pino
Comment 4 2021-11-03 23:53:51 PDT
Created attachment 443278 [details] Patch
EWS
Comment 5 2021-11-04 05:36:59 PDT
Committed r285260 (243871@main): <https://commits.webkit.org/243871@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443278 [details].
Radar WebKit Bug Importer
Comment 6 2021-11-04 05:38:19 PDT
<rdar://problem/85014283>
Note You need to log in before you can comment on or make changes to this bug.