| Summary: | [fast-cq] Require MediaSessionCoordinator enabled to enable MediaSession PlayList API | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||
| Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, bugs-noreply, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, zdobersek | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=232687 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Diego Pino
2021-11-03 21:07:08 PDT
Created attachment 443269 [details]
Patch
Created attachment 443270 [details]
Patch
r285241 enabled MediaSession PlayList API on the condition `WebKit::defaultMediaSessionCoordinatorEnabled()`, but definition of that function is guarded by ENABLE(MEDIA_SESSION_COORDINATOR) (https://webkit-search.igalia.com/webkit/source/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp#333). The flag is disabled in WebKitGTK/WPE (https://webkit-search.igalia.com/webkit/source/Source/cmake/WebKitFeatures.cmake#171), which caused r285241 to break compilation in WebKitGTK/WPE. https://build.webkit.org/#/builders/41/builds/7221 ``` /app/webkit/WebKitBuild/Release/DerivedSources/WebKit/WebPreferencesDefinitions.h:621:63: error: ‘defaultMediaSessionCoordinatorEnabled’ is not a member of ‘WebKit’ 621 | #define DEFAULT_VALUE_FOR_MediaSessionPlaylistEnabled WebKit::defaultMediaSessionCoordinatorEnabled() | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Created attachment 443278 [details]
Patch
Committed r285260 (243871@main): <https://commits.webkit.org/243871@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443278 [details]. |