Bug 232690 – [Cocoa] Migrate from CTFontCopyVariationAxes() to CTFontCopyVariationAxesInternal() if possible

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

[Cocoa] Migrate from CTFontCopyVariationAxes() to CTFontCopyVariationAxesInternal() if possible

[Myles C. Maxfield]

Created attachment 443255 [details]
Patch

[Myles C. Maxfield]

Created attachment 443271 [details]
Patch

[Myles C. Maxfield]

Created attachment 443272 [details]
Patch

[Myles C. Maxfield]

Created attachment 443273 [details]
Patch

[Myles C. Maxfield]

Created attachment 443275 [details]
Patch

[Myles C. Maxfield]

Created attachment 443279 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 443279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443279&action=review

> Source/WebCore/platform/graphics/ShouldLocalizeAxisNames.h:35
> +enum class ShouldLocalizeAxisNames : uint8_t {
> +    No,
> +    Yes
> +};

Is there a reason this can't just live in FontPlatformData.h?

[Cameron McCormack (:heycam)]

Comment on attachment 443279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443279&action=review

> Source/WebCore/platform/graphics/ShouldLocalizeAxisNames.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

2021 (if you don't end up moving it)

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:305
> +#if defined(HAVE_CTFontCopyVariationAxesInternal) // This macro is defined inside CoreText, not WebKit.

Thanks for the comment otherwise I would've complained about the capitalization here. :-)

[Myles C. Maxfield]

Committed r285318 (243890@main): <https://commits.webkit.org/243890@main>

[Myles C. Maxfield]

Comment on attachment 443279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443279&action=review

>> Source/WebCore/platform/graphics/ShouldLocalizeAxisNames.h:35
>> +};
> 
> Is there a reason this can't just live in FontPlatformData.h?

I would have preferred to put this in a common place, but this has to be visible from both FontPlatformData.h and FontCacheCoreText.h. There is no header (that isn't single-purpose like FontTaggedSettings.h or FontSelectionAlgorithm.h) which is included from both of those places.

[Radar WebKit Bug Importer]

<rdar://problem/85038305>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 232894

[Myles C. Maxfield]

Committed r285552 (244066@main): <https://commits.webkit.org/244066@main>