Bug 232689

Summary: Crash when opening and closing color picker while resetting form
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch for landing none

Description Aditya Keerthi 2021-11-03 16:34:10 PDT
...
Comment 1 Aditya Keerthi 2021-11-03 16:34:26 PDT
rdar://84979791
Comment 2 Aditya Keerthi 2021-11-03 16:36:50 PDT
Created attachment 443252 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-11-03 16:40:04 PDT
Comment on attachment 443252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443252&action=review

> LayoutTests/fast/forms/color/color-input-reset-crash.html:27
> +    await UIHelper.delayFor(interval);

Can we make this test take less than 1000ms?
Comment 4 Aditya Keerthi 2021-11-03 16:51:11 PDT
Created attachment 443254 [details]
Patch for landing
Comment 5 Aditya Keerthi 2021-11-03 16:52:10 PDT
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 443252 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443252&action=review
> 
> > LayoutTests/fast/forms/color/color-input-reset-crash.html:27
> > +    await UIHelper.delayFor(interval);
> 
> Can we make this test take less than 1000ms?

Reduced to 100ms, after verifying the test still fails without the fix.
Comment 6 EWS 2021-11-04 13:35:54 PDT
Committed r285306 (243885@main): <https://commits.webkit.org/243885@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443254 [details].