Bug 232659
| Summary: | Release+assert build broken due to ColorTypes.h assertInRange | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | WebCore Misc. | Assignee: | Sam Weinig <sam> |
| Status: | ASSIGNED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kimmo Kinnunen
Release+assert build broken due to ColorTypes.h assertInRange
assertInRange cannot be constexpr due to it using ASSERT. Conceptually if it fails, we don't want the compiler to assert.
ColorSpace.h starts a call chain that invokes the assertInRange in non-constexpr context, so the assert cannot be static_assert.
make ra
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kimmo Kinnunen
also: callWithColorType std::invoke is not constexpr in c++17.
Radar WebKit Bug Importer
<rdar://problem/85244408>