Bug 232652

Summary:

[JSC] Clean up StructureStubInfo initialization

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

REOPENED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, pangle, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

232907

Bug Blocks:

Attachments:

Description	Flags
Patch	saam: review+, ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Yusuke Suzuki

Reported 2021-11-02 19:38:33 PDT

[JSC] Clean up StructureStubInfo initialization

Attachments
Patch (17.62 KB, patch) 2021-11-02 19:40 PDT, Yusuke Suzuki	saam: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (17.83 KB, patch) 2021-11-03 09:53 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (19.33 KB, patch) 2021-11-03 10:44 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (19.98 KB, patch) 2021-11-03 12:13 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (19.98 KB, patch) 2021-11-03 12:37 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (20.48 KB, patch) 2021-11-03 13:42 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2021-11-02 19:40:29 PDT

Created attachment 443164 [details] Patch

Saam Barati

Comment 2 2021-11-02 19:47:55 PDT

Comment on attachment 443164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443164&action=review > Source/WTF/wtf/FixedVector.h:68 > + : m_storage(std::forward<Container>(other)) Why forward? > Source/WTF/wtf/FixedVector.h:74 > + m_storage = std::forward<Container>(other); Why forward?

Yusuke Suzuki

Comment 3 2021-11-03 09:53:14 PDT

Created attachment 443205 [details] Patch

Yusuke Suzuki

Comment 4 2021-11-03 09:56:09 PDT

Comment on attachment 443164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443164&action=review >> Source/WTF/wtf/FixedVector.h:68 >> + : m_storage(std::forward<Container>(other)) > > Why forward? Since this Container can become rvalue and lvalue (using Container&& templatized value in the parameter). std::forward handles both cases. https://en.cppreference.com/w/cpp/utility/forward >> Source/WTF/wtf/FixedVector.h:74 >> + m_storage = std::forward<Container>(other); > > Why forward? Ditto

Yusuke Suzuki

Comment 5 2021-11-03 10:44:43 PDT

Created attachment 443211 [details] Patch

Yusuke Suzuki

Comment 6 2021-11-03 12:13:15 PDT

Created attachment 443221 [details] Patch

Yusuke Suzuki

Comment 7 2021-11-03 12:37:15 PDT

Created attachment 443226 [details] Patch

Yusuke Suzuki

Comment 8 2021-11-03 13:42:59 PDT

Created attachment 443235 [details] Patch