REOPENED232652
[JSC] Clean up StructureStubInfo initialization 
https://bugs.webkit.org/show_bug.cgi?id=232652
Summary [JSC] Clean up StructureStubInfo initialization
Yusuke Suzuki
Reported 2021-11-02 19:38:33 PDT
[JSC] Clean up StructureStubInfo initialization
Attachments
Patch (17.62 KB, patch)
2021-11-02 19:40 PDT, Yusuke Suzuki 		saam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.83 KB, patch)
2021-11-03 09:53 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (19.33 KB, patch)
2021-11-03 10:44 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (19.98 KB, patch)
2021-11-03 12:13 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (19.98 KB, patch)
2021-11-03 12:37 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (20.48 KB, patch)
2021-11-03 13:42 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-11-02 19:40:29 PDT
Created attachment 443164 [details] Patch
Saam Barati
Comment 2 2021-11-02 19:47:55 PDT
Comment on attachment 443164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443164&action=review > Source/WTF/wtf/FixedVector.h:68 > + : m_storage(std::forward<Container>(other)) Why forward? > Source/WTF/wtf/FixedVector.h:74 > + m_storage = std::forward<Container>(other); Why forward?
Yusuke Suzuki
Comment 3 2021-11-03 09:53:14 PDT
Created attachment 443205 [details] Patch
Yusuke Suzuki
Comment 4 2021-11-03 09:56:09 PDT
Comment on attachment 443164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443164&action=review >> Source/WTF/wtf/FixedVector.h:68 >> + : m_storage(std::forward<Container>(other)) > > Why forward? Since this Container can become rvalue and lvalue (using Container&& templatized value in the parameter). std::forward handles both cases. https://en.cppreference.com/w/cpp/utility/forward >> Source/WTF/wtf/FixedVector.h:74 >> + m_storage = std::forward<Container>(other); > > Why forward? Ditto
Yusuke Suzuki
Comment 5 2021-11-03 10:44:43 PDT
Created attachment 443211 [details] Patch
Yusuke Suzuki
Comment 6 2021-11-03 12:13:15 PDT
Created attachment 443221 [details] Patch
Yusuke Suzuki
Comment 7 2021-11-03 12:37:15 PDT
Created attachment 443226 [details] Patch
Yusuke Suzuki
Comment 8 2021-11-03 13:42:59 PDT
Created attachment 443235 [details] Patch
Yusuke Suzuki
Comment 9 2021-11-03 17:05:48 PDT
Committed r285246 (243861@main): <https://commits.webkit.org/243861@main>
Radar WebKit Bug Importer
Comment 10 2021-11-03 17:06:20 PDT
<rdar://problem/84998450>
WebKit Commit Bot
Comment 11 2021-11-09 15:04:00 PST
Re-opened since this is blocked by bug 232907
Note You need to log in before you can comment on or make changes to this bug.