Bug 232652 - [JSC] Clean up StructureStubInfo initialization
Summary: [JSC] Clean up StructureStubInfo initialization
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 232907
Blocks:
  Show dependency tree / graph
 
Reported: 2021-11-02 19:38 PDT by Yusuke Suzuki
Modified: 2021-11-09 15:04 PST (History)
14 users (show)

See Also:

Attachments
Patch (17.62 KB, patch)
2021-11-02 19:40 PDT, Yusuke Suzuki 		saam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.83 KB, patch)
2021-11-03 09:53 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (19.33 KB, patch)
2021-11-03 10:44 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (19.98 KB, patch)
2021-11-03 12:13 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (19.98 KB, patch)
2021-11-03 12:37 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (20.48 KB, patch)
2021-11-03 13:42 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-11-02 19:38:33 PDT 
[JSC] Clean up StructureStubInfo initialization
Comment 1 Yusuke Suzuki 2021-11-02 19:40:29 PDT 
Created attachment 443164 [details]
Patch
Comment 2 Saam Barati 2021-11-02 19:47:55 PDT 
Comment on attachment 443164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443164&action=review

> Source/WTF/wtf/FixedVector.h:68
> +        : m_storage(std::forward<Container>(other))

Why forward?

> Source/WTF/wtf/FixedVector.h:74
> +        m_storage = std::forward<Container>(other);

Why forward?
Comment 3 Yusuke Suzuki 2021-11-03 09:53:14 PDT 
Created attachment 443205 [details]
Patch
Comment 4 Yusuke Suzuki 2021-11-03 09:56:09 PDT 
Comment on attachment 443164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443164&action=review

>> Source/WTF/wtf/FixedVector.h:68
>> +        : m_storage(std::forward<Container>(other))
> 
> Why forward?

Since this Container can become rvalue and lvalue (using Container&& templatized value in the parameter).
std::forward handles both cases. https://en.cppreference.com/w/cpp/utility/forward

>> Source/WTF/wtf/FixedVector.h:74
>> +        m_storage = std::forward<Container>(other);
> 
> Why forward?

Ditto
Comment 5 Yusuke Suzuki 2021-11-03 10:44:43 PDT 
Created attachment 443211 [details]
Patch
Comment 6 Yusuke Suzuki 2021-11-03 12:13:15 PDT 
Created attachment 443221 [details]
Patch
Comment 7 Yusuke Suzuki 2021-11-03 12:37:15 PDT 
Created attachment 443226 [details]
Patch
Comment 8 Yusuke Suzuki 2021-11-03 13:42:59 PDT 
Created attachment 443235 [details]
Patch
Comment 9 Yusuke Suzuki 2021-11-03 17:05:48 PDT 
Committed r285246 (243861@main): <https://commits.webkit.org/243861@main>
Comment 10 Radar WebKit Bug Importer 2021-11-03 17:06:20 PDT 
<rdar://problem/84998450>
Comment 11 WebKit Commit Bot 2021-11-09 15:04:00 PST 
Re-opened since this is blocked by bug 232907