| Summary: | Make scroll bar mode an enum class | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikos Mouchtaris <nmouchtaris> | ||||||||||||||
| Component: | New Bugs | Assignee: | Nikos Mouchtaris <nmouchtaris> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, jamesr, kondapallykalyan, luiz, pdr, simon.fraser, tonikitoo, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Nikos Mouchtaris
2021-11-02 18:48:39 PDT
Created attachment 443158 [details]
Patch
Created attachment 443175 [details]
Patch
Comment on attachment 443175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443175&action=review > Source/WebCore/page/FrameView.cpp:3525 > + ScrollbarMode horizonalScrollbarMode = ScrollbarMode::AlwaysOff; > + ScrollbarMode verticalScrollbarMode = ScrollbarMode::AlwaysOff; These could use auto. > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:393 > + ts.dumpProperty("horizontal scrollbar mode", static_cast<int>(scrollableAreaParameters.horizontalScrollbarMode)); > + ts.dumpProperty("vertical scrollbar mode", static_cast<int>(scrollableAreaParameters.verticalScrollbarMode)); Ideally you'd fix this by implementing TextStream& operator<<(TextStream& ts, ScrollbarMode) Created attachment 443251 [details]
Patch
Created attachment 443265 [details]
Patch
Created attachment 443425 [details]
Patch
Created attachment 443428 [details]
Patch
Committed r285357 (243916@main): <https://commits.webkit.org/243916@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443428 [details]. |