Bug 232648

Summary: Make scrollbar orientation an enum class
Product: WebKit Reporter: Nikos Mouchtaris <nmouchtaris>
Component: New BugsAssignee: Nikos Mouchtaris <nmouchtaris>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, allan.jensen, andresg_22, apinheiro, cdumez, cfleizach, changseok, cmarcelo, dmazzoni, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, jamesr, jcraig, jdiggs, kondapallykalyan, luiz, macpherson, menard, mifenton, pdr, samuel_white, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+, ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Nikos Mouchtaris
Reported 2021-11-02 17:29:43 PDT
Make scrollbar orientation an enum class
Attachments
Patch (57.72 KB, patch)
2021-11-02 17:31 PDT, Nikos Mouchtaris 		simon.fraser: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (80.84 KB, patch)
2021-11-03 17:15 PDT, Nikos Mouchtaris 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (82.29 KB, patch)
2021-11-04 12:21 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikos Mouchtaris
Comment 1 2021-11-02 17:31:25 PDT
Created attachment 443152 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-11-02 18:48:42 PDT
Comment on attachment 443152 [details] Patch r+ but you need to fix the gtk/wpe/win builds.
Nikos Mouchtaris
Comment 3 2021-11-03 17:15:40 PDT
Created attachment 443259 [details] Patch
Nikos Mouchtaris
Comment 4 2021-11-04 12:21:36 PDT
Created attachment 443332 [details] Patch
EWS
Comment 5 2021-11-04 14:58:38 PDT
Committed r285316 (243888@main): <https://commits.webkit.org/243888@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443332 [details].
Radar WebKit Bug Importer
Comment 6 2021-11-04 14:59:17 PDT
<rdar://problem/85034984>
Note You need to log in before you can comment on or make changes to this bug.