Bug 232648 - Make scrollbar orientation an enum class
Summary: Make scrollbar orientation an enum class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikos Mouchtaris
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-02 17:29 PDT by Nikos Mouchtaris
Modified: 2021-11-04 14:59 PDT (History)
27 users (show)

See Also:

Attachments
Patch (57.72 KB, patch)
2021-11-02 17:31 PDT, Nikos Mouchtaris 		simon.fraser: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (80.84 KB, patch)
2021-11-03 17:15 PDT, Nikos Mouchtaris 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (82.29 KB, patch)
2021-11-04 12:21 PDT, Nikos Mouchtaris 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Mouchtaris 2021-11-02 17:29:43 PDT 
Make scrollbar orientation an enum class
Comment 1 Nikos Mouchtaris 2021-11-02 17:31:25 PDT 
Created attachment 443152 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-11-02 18:48:42 PDT 
Comment on attachment 443152 [details]
Patch

r+ but you need to fix the gtk/wpe/win builds.
Comment 3 Nikos Mouchtaris 2021-11-03 17:15:40 PDT 
Created attachment 443259 [details]
Patch
Comment 4 Nikos Mouchtaris 2021-11-04 12:21:36 PDT 
Created attachment 443332 [details]
Patch
Comment 5 EWS 2021-11-04 14:58:38 PDT 
Committed r285316 (243888@main): <https://commits.webkit.org/243888@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443332 [details].
Comment 6 Radar WebKit Bug Importer 2021-11-04 14:59:17 PDT 
<rdar://problem/85034984>