Bug 232647

Summary: Remove ReduceLoopStrength
Product: WebKit Reporter: Justin Michaud <justin_michaud>
Component: JavaScriptCoreAssignee: Justin Michaud <justin_michaud>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230908    
Attachments:
Description Flags
Patch justin_michaud: review?

Justin Michaud
Reported 2021-11-02 17:04:10 PDT
After the introduction of WasmAddress, this pass no longer does anything. It will likely only ever be profitable for WASM, and in addition, the pattern matching is pretty fragile. For now, we should remove it, and consider re-adding it when we need a JetStream progression. Here are some additional thoughts that we should consider before we add it back: 1) We consider hoisting WasmAddress in LICM or as a peephole optimization 2) We should support ARM64: see 230908 3) If we get SIMD/memcpy instruction support, we should consider inlining memcpy 4) We should make the pattern matching more general
Attachments
Patch (33.68 KB, patch)
2021-11-02 17:07 PDT, Justin Michaud 		justin_michaud: review?
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Michaud
Comment 1 2021-11-02 17:07:55 PDT
Created attachment 443149 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-11-09 16:05:31 PST
<rdar://problem/85228080>
Justin Michaud
Comment 3 2024-04-08 13:37:18 PDT
Closing old bugs assigned to me
Note You need to log in before you can comment on or make changes to this bug.