Summary: | [JSC] Add LLInt fast path for OpMod on x86_64 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ross Kirsling
2021-11-02 15:21:51 PDT
Created attachment 443140 [details]
Patch
Comment on attachment 443140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443140&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1294 > + loadConstantOrVariable(size, t0, t1) > + loadConstantOrVariable(size, t2, t0) > + bqb t0, numberTag, .slow > + bqb t1, numberTag, .slow Maybe loadConstantOrVariableInt32? Comment on attachment 443140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443140&action=review r=me too > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1306 > + # Assume t3 is scratchable. > + move t1, t3 > + move t0, t0 > + cdqi > + idivi t3 > + bigteq t0, 0, .notNegZero > + btiz r1, .slow Let's add static_assert with GPRInfo::regTX to ensure that these registers are specific ones. (e.g. regT0 should be eax, and let's comment about r1 is always edx.) Created attachment 443155 [details]
Patch for landing
Committed r285197 (243823@main): <https://commits.webkit.org/243823@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443155 [details]. |