Bug 232641

Summary:

Make scroll granularity an enum class

Product:

WebKit

Reporter:

Nikos Mouchtaris <nmouchtaris>

Component:

New Bugs

Assignee:

Nikos Mouchtaris <nmouchtaris>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, glenn, heycam, kangil.han, kondapallykalyan, mifenton, pdr, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	heycam: review+, ews-feeder: commit-queue-
Patch	none

Nikos Mouchtaris

Reported 2021-11-02 14:44:05 PDT

Make scroll granularity an enum class

Attachments
Patch (30.35 KB, patch) 2021-11-02 14:45 PDT, Nikos Mouchtaris	no flags	Details Formatted Diff Diff
Patch (33.01 KB, patch) 2021-11-04 14:32 PDT, Nikos Mouchtaris	no flags	Details Formatted Diff Diff
Patch (36.51 KB, patch) 2021-11-04 17:22 PDT, Nikos Mouchtaris	no flags	Details Formatted Diff Diff
Patch (40.01 KB, patch) 2021-11-08 10:52 PST, Nikos Mouchtaris	no flags	Details Formatted Diff Diff
Patch (41.77 KB, patch) 2021-11-08 12:33 PST, Nikos Mouchtaris	no flags	Details Formatted Diff Diff
Patch (42.14 KB, patch) 2021-11-10 16:03 PST, Nikos Mouchtaris	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (47.70 KB, patch) 2021-11-10 17:22 PST, Nikos Mouchtaris	no flags	Details Formatted Diff Diff
Patch (45.19 KB, patch) 2021-11-10 17:38 PST, Nikos Mouchtaris	heycam: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (45.17 KB, patch) 2021-11-10 23:00 PST, Nikos Mouchtaris	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Nikos Mouchtaris

Comment 1 2021-11-02 14:45:52 PDT

Created attachment 443137 [details] Patch

Nikos Mouchtaris

Comment 2 2021-11-04 14:32:14 PDT

Created attachment 443340 [details] Patch

Nikos Mouchtaris

Comment 3 2021-11-04 17:22:06 PDT

Created attachment 443360 [details] Patch

Nikos Mouchtaris

Comment 4 2021-11-08 10:52:21 PST

Created attachment 443573 [details] Patch

Nikos Mouchtaris

Comment 5 2021-11-08 12:33:23 PST

Created attachment 443589 [details] Patch

Cameron McCormack (:heycam)

Comment 6 2021-11-08 19:52:41 PST

Comment on attachment 443589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443589&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:3272 > + send(Messages::WebPage::ScrollBy(direction, static_cast<uint32_t>(granularity))); Can you make the IPC message take the enum directly? You should be able to change WebPage.messages.in to use `enum:uint8_t WebCore::ScrollGranularity` or so.

Cameron McCormack (:heycam)

Comment 7 2021-11-08 19:56:51 PST

(In reply to Cameron McCormack (:heycam) from comment #6) > Can you make the IPC message take the enum directly? You should be able to > change WebPage.messages.in to use `enum:uint8_t WebCore::ScrollGranularity` > or so. And that might need doing some EnumTraits stuff to get that to work. The rest of the patch looked fine, but I'll wait to see another version.

Radar WebKit Bug Importer

Comment 8 2021-11-09 13:45:23 PST

<rdar://problem/85219827>

Cameron McCormack (:heycam)

Comment 9 2021-11-09 17:38:51 PST

*** Bug 232575 has been marked as a duplicate of this bug. ***

Nikos Mouchtaris

Comment 10 2021-11-10 16:03:27 PST

Created attachment 443875 [details] Patch

Nikos Mouchtaris

Comment 11 2021-11-10 17:22:59 PST

Created attachment 443879 [details] Patch