Bug 232600

Summary:

[LFC][IFC] Pass in the visual order list to display box construction

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2021-11-01 18:56:22 PDT

so that we can start constructing the display boxes based on the visual order.

Comment 1 zalan 2021-11-01 19:00:48 PDT

Created attachment 443051 [details]
Patch

Comment 2 Antti Koivisto 2021-11-02 01:04:20 PDT

Comment on attachment 443051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443051&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:298
> +        ubidi_reorderVisual(runLevels.data(), runLevels.size(), visualOrderList.data());

boom

Comment 3 EWS 2021-11-02 07:56:52 PDT

Committed r285157 (243793@main): <https://commits.webkit.org/243793@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443051 [details].

Comment 4 Radar WebKit Bug Importer 2021-11-02 07:57:15 PDT

<rdar://problem/84930881>