Bug 232600 - [LFC][IFC] Pass in the visual order list to display box construction
Summary: [LFC][IFC] Pass in the visual order list to display box construction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-01 18:56 PDT by zalan
Modified: 2021-11-02 07:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.83 KB, patch)
2021-11-01 19:00 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-11-01 18:56:22 PDT 
so that we can start constructing the display boxes based on the visual order.
Comment 1 zalan 2021-11-01 19:00:48 PDT 
Created attachment 443051 [details]
Patch
Comment 2 Antti Koivisto 2021-11-02 01:04:20 PDT 
Comment on attachment 443051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443051&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:298
> +        ubidi_reorderVisual(runLevels.data(), runLevels.size(), visualOrderList.data());

boom
Comment 3 EWS 2021-11-02 07:56:52 PDT 
Committed r285157 (243793@main): <https://commits.webkit.org/243793@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443051 [details].
Comment 4 Radar WebKit Bug Importer 2021-11-02 07:57:15 PDT 
<rdar://problem/84930881>