Bug 232598

Summary: [JSC][LLInt] Non-commutative binops are hard to reason about when operands are labelled in reverse
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ross Kirsling 2021-11-01 17:45:10 PDT 
[JSC][LLInt] Non-commutative binops are hard to reason about when toperands are labelled in reverse
Comment 1 Ross Kirsling 2021-11-01 18:11:12 PDT 
Created attachment 443046 [details]
Patch
Comment 2 Saam Barati 2021-11-01 18:31:19 PDT 
Comment on attachment 443046 [details]
Patch

Nice. r=me
Comment 3 Ross Kirsling 2021-11-01 19:14:53 PDT 
Created attachment 443052 [details]
Patch
Comment 4 EWS 2021-11-01 20:42:41 PDT 
Committed r285152 (243789@main): <https://commits.webkit.org/243789@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443052 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-01 20:43:17 PDT 
<rdar://problem/84913491>