Bug 232598 - [JSC][LLInt] Non-commutative binops are hard to reason about when operands are labelled in reverse
Summary: [JSC][LLInt] Non-commutative binops are hard to reason about when operands ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-01 17:45 PDT by Ross Kirsling
Modified: 2021-11-01 20:43 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.99 KB, patch)
2021-11-01 18:11 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (11.87 KB, patch)
2021-11-01 19:14 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2021-11-01 17:45:10 PDT 
[JSC][LLInt] Non-commutative binops are hard to reason about when toperands are labelled in reverse
Comment 1 Ross Kirsling 2021-11-01 18:11:12 PDT 
Created attachment 443046 [details]
Patch
Comment 2 Saam Barati 2021-11-01 18:31:19 PDT 
Comment on attachment 443046 [details]
Patch

Nice. r=me
Comment 3 Ross Kirsling 2021-11-01 19:14:53 PDT 
Created attachment 443052 [details]
Patch
Comment 4 EWS 2021-11-01 20:42:41 PDT 
Committed r285152 (243789@main): <https://commits.webkit.org/243789@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443052 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-01 20:43:17 PDT 
<rdar://problem/84913491>