Bug 232571

Summary: [LFC][IFC] Stop measuring text while collecting inline items when content needs bidi split
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

zalan
Reported 2021-11-01 10:37:02 PDT
bidi boundaries may be different from inline item boundaries.
Attachments
Patch (5.49 KB, patch)
2021-11-01 10:41 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.53 KB, patch)
2021-11-01 10:45 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.53 KB, patch)
2021-11-01 10:50 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.53 KB, patch)
2021-11-01 14:39 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-11-01 10:41:57 PDT
Created attachment 442990 [details] Patch
zalan
Comment 2 2021-11-01 10:45:38 PDT
Created attachment 442991 [details] Patch
Antti Koivisto
Comment 3 2021-11-01 10:50:08 PDT
Comment on attachment 442991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442991&action=review > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h:57 > + bool hasSeenBiDiContent() const { return !m_paragraphContentBuilder.isEmpty(); } Lets stay with bidi/Bidi since that is what most of the code uses.
zalan
Comment 4 2021-11-01 10:50:57 PDT
Created attachment 442993 [details] Patch
EWS
Comment 5 2021-11-01 14:22:53 PDT
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
zalan
Comment 6 2021-11-01 14:39:27 PDT
Created attachment 443018 [details] Patch
EWS
Comment 7 2021-11-01 15:09:51 PDT
Committed r285136 (243775@main): <https://commits.webkit.org/243775@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443018 [details].
Radar WebKit Bug Importer
Comment 8 2021-11-01 15:10:21 PDT
<rdar://problem/84901941>
Note You need to log in before you can comment on or make changes to this bug.