Bug 232562

Summary: Use Style::ScopeOrdinal for finding the right scope for ::part matching
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, macpherson, menard, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch for landing none

Antti Koivisto
Reported 2021-11-01 05:36:17 PDT
Get rid of the awkward shadowHostInPartRuleScope state.
Attachments
Patch (17.51 KB, patch)
2021-11-01 05:45 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (17.88 KB, patch)
2021-11-01 05:47 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (17.88 KB, patch)
2021-11-01 06:01 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (15.88 KB, patch)
2021-11-01 09:15 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (15.91 KB, patch)
2021-11-01 09:53 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (15.54 KB, patch)
2021-11-01 10:46 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.54 KB, patch)
2021-11-03 03:14 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-11-01 05:45:17 PDT
Created attachment 442969 [details] Patch
Antti Koivisto
Comment 2 2021-11-01 05:47:31 PDT
Created attachment 442970 [details] Patch
Antti Koivisto
Comment 3 2021-11-01 06:01:30 PDT
Created attachment 442971 [details] Patch
Antti Koivisto
Comment 4 2021-11-01 09:15:46 PDT
Created attachment 442981 [details] Patch
Antti Koivisto
Comment 5 2021-11-01 09:53:07 PDT
Created attachment 442986 [details] Patch
Antti Koivisto
Comment 6 2021-11-01 10:46:38 PDT
Created attachment 442992 [details] Patch
Simon Fraser (smfr)
Comment 7 2021-11-02 13:18:02 PDT
Comment on attachment 442992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442992&action=review > Source/WebCore/ChangeLog:8 > + We are passing the scope ordinal to the selector checker so we can use it consistently to find are already passing? Or new in this patch? > Source/WebCore/style/StyleScopeOrdinal.h:51 > + > + Extra blank line.
Antti Koivisto
Comment 8 2021-11-03 03:14:42 PDT
Created attachment 443184 [details] Patch for landing
EWS
Comment 9 2021-11-03 03:59:27 PDT
Committed r285202 (243828@main): <https://commits.webkit.org/243828@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443184 [details].
Radar WebKit Bug Importer
Comment 10 2021-11-03 04:00:21 PDT
<rdar://problem/84968497>
Note You need to log in before you can comment on or make changes to this bug.