| Summary: | [LFC][IFC] Start using ubidi to find bidi boundaries | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2021-10-31 21:16:07 PDT
Created attachment 442953 [details]
Patch
Comment on attachment 442953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442953&action=review > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:136 > +void InlineItemsBuilder::breakInlineItemsAtBidiBoundaries(InlineItems& inlineItems) breakAndComputeBidiLevels() or something? (InlineItems is bit redundant since we are in InlineItemBuilder). Comment on attachment 442953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442953&action=review > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:156 > + ubidi_close(ubidi); could use ScopeExit for safe closing. Created attachment 442988 [details]
Patch
Committed r285119 (243760@main): <https://commits.webkit.org/243760@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442988 [details]. |