WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
232552
[LFC][IFC] Start using ubidi to find bidi boundaries
https://bugs.webkit.org/show_bug.cgi?id=232552
Summary
[LFC][IFC] Start using ubidi to find bidi boundaries
zalan
Reported
2021-10-31 21:16:07 PDT
ssia
Attachments
Patch
(7.96 KB, patch)
2021-10-31 21:33 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(9.04 KB, patch)
2021-11-01 10:19 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2021-10-31 21:33:43 PDT
Created
attachment 442953
[details]
Patch
Antti Koivisto
Comment 2
2021-10-31 23:03:57 PDT
Comment on
attachment 442953
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=442953&action=review
> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:136 > +void InlineItemsBuilder::breakInlineItemsAtBidiBoundaries(InlineItems& inlineItems)
breakAndComputeBidiLevels() or something? (InlineItems is bit redundant since we are in InlineItemBuilder).
Antti Koivisto
Comment 3
2021-11-01 09:24:25 PDT
Comment on
attachment 442953
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=442953&action=review
> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:156 > + ubidi_close(ubidi);
could use ScopeExit for safe closing.
zalan
Comment 4
2021-11-01 10:19:51 PDT
Created
attachment 442988
[details]
Patch
EWS
Comment 5
2021-11-01 12:22:27 PDT
Committed
r285119
(
243760@main
): <
https://commits.webkit.org/243760@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 442988
[details]
.
Radar WebKit Bug Importer
Comment 6
2021-11-01 12:23:50 PDT
<
rdar://problem/84893664
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug