Bug 232552 - [LFC][IFC] Start using ubidi to find bidi boundaries
Summary: [LFC][IFC] Start using ubidi to find bidi boundaries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-31 21:16 PDT by zalan
Modified: 2021-11-01 12:23 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.96 KB, patch)
2021-10-31 21:33 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (9.04 KB, patch)
2021-11-01 10:19 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-10-31 21:16:07 PDT
ssia
Comment 1 zalan 2021-10-31 21:33:43 PDT
Created attachment 442953 [details]
Patch
Comment 2 Antti Koivisto 2021-10-31 23:03:57 PDT
Comment on attachment 442953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442953&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:136
> +void InlineItemsBuilder::breakInlineItemsAtBidiBoundaries(InlineItems& inlineItems)

breakAndComputeBidiLevels() or something? (InlineItems is bit redundant since we are in InlineItemBuilder).
Comment 3 Antti Koivisto 2021-11-01 09:24:25 PDT
Comment on attachment 442953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442953&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:156
> +        ubidi_close(ubidi);

could use ScopeExit for safe closing.
Comment 4 zalan 2021-11-01 10:19:51 PDT
Created attachment 442988 [details]
Patch
Comment 5 EWS 2021-11-01 12:22:27 PDT
Committed r285119 (243760@main): <https://commits.webkit.org/243760@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442988 [details].
Comment 6 Radar WebKit Bug Importer 2021-11-01 12:23:50 PDT
<rdar://problem/84893664>