| Summary: | [WebGPU] Bindings part 1: Bring back Adapter/Device bindings code | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, annulen, benjamin, calvaris, cdumez, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, jiewen_tan, kangil.han, kondapallykalyan, philipj, rmorisset, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||
| Bug Depends on: | 232541, 232549 | ||||||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||
|
Description
Myles C. Maxfield
2021-10-31 15:44:35 PDT
Created attachment 442942 [details]
WIP
Created attachment 442943 [details]
WIP
Created attachment 442944 [details]
WIP
Created attachment 442948 [details]
WIP
Created attachment 442958 [details]
WIP
Created attachment 442960 [details]
WIP
Created attachment 442961 [details]
WIP
Created attachment 442962 [details]
WIP
Created attachment 442963 [details]
WIP
Created attachment 442964 [details]
WIP
Comment on attachment 442964 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=442964&action=review > Source/WebCore/Modules/WebGPU/GPUAdapter.h:40 > + static Ref<GPUAdapter> create(const String& name, Ref<GPUSupportedFeatures>&& features, Ref<GPUSupportedLimits>&& limits, bool isFallbackAdapter) String&& is probably better. Created attachment 443043 [details]
Patch
Created attachment 443044 [details]
Patch
Comment on attachment 443044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review > Source/WebCore/Modules/WebGPU/GPU.cpp:35 > + nit: extra space > Source/WebCore/Modules/WebGPU/GPUAdapter.cpp:35 > + ditto > Source/WebCore/bindings/scripts/CodeGenerator.pm:198 > - die "Processing document " . $useDocument->fileName . " did not generate anything."; > + # die "Processing document " . $useDocument->fileName . " did not generate anything."; Don't commit this. Comment on attachment 443044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review > Source/WebCore/Modules/WebGPU/GPUDevice.h:54 > + const char* activeDOMObjectName() const final { return "GPUDevice"; } Private. Comment on attachment 443044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review > Source/WebCore/Modules/WebGPU/GPUDevice.cpp:31 > +GPUDevice::~GPUDevice() = default Created attachment 443367 [details]
Patch for committing
Committed r285376 (243933@main): <https://commits.webkit.org/243933@main> |