Bug 232550

Summary: [WebGPU] Bindings part 1: Bring back Adapter/Device bindings code
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, benjamin, calvaris, cdumez, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, jiewen_tan, kangil.han, kondapallykalyan, philipj, rmorisset, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232541, 232549    
Bug Blocks:    
Attachments:
Description Flags
WIP
ews-feeder: commit-queue-
WIP
ews-feeder: commit-queue-
WIP
none
WIP
none
WIP
ews-feeder: commit-queue-
WIP
ews-feeder: commit-queue-
WIP
ews-feeder: commit-queue-
WIP
ews-feeder: commit-queue-
WIP
ews-feeder: commit-queue-
WIP
none
Patch
none
Patch
achristensen: review+, achristensen: commit-queue-
Patch for committing none

Myles C. Maxfield
Reported 2021-10-31 15:44:35 PDT
[WebGPU] Bindings part 1: Bring back Adapter/Device bindings code
Attachments
WIP (105.17 KB, patch)
2021-10-31 15:46 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP (105.08 KB, patch)
2021-10-31 15:52 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP (109.08 KB, patch)
2021-10-31 16:18 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (109.23 KB, patch)
2021-10-31 20:10 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (110.58 KB, patch)
2021-10-31 22:36 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP (112.08 KB, patch)
2021-10-31 22:45 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP (105.26 KB, patch)
2021-10-31 22:57 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP (105.83 KB, patch)
2021-10-31 23:03 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP (105.92 KB, patch)
2021-10-31 23:21 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP (105.97 KB, patch)
2021-10-31 23:25 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (95.60 KB, patch)
2021-11-01 17:44 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (95.58 KB, patch)
2021-11-01 17:49 PDT, Myles C. Maxfield 		achristensen: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (93.81 KB, patch)
2021-11-04 18:38 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-10-31 15:46:34 PDT
Created attachment 442942 [details] WIP
Myles C. Maxfield
Comment 2 2021-10-31 15:52:40 PDT
Created attachment 442943 [details] WIP
Myles C. Maxfield
Comment 3 2021-10-31 16:18:40 PDT
Created attachment 442944 [details] WIP
Myles C. Maxfield
Comment 4 2021-10-31 20:10:21 PDT
Created attachment 442948 [details] WIP
Myles C. Maxfield
Comment 5 2021-10-31 22:36:48 PDT
Created attachment 442958 [details] WIP
Myles C. Maxfield
Comment 6 2021-10-31 22:45:29 PDT
Created attachment 442960 [details] WIP
Myles C. Maxfield
Comment 7 2021-10-31 22:57:59 PDT
Created attachment 442961 [details] WIP
Myles C. Maxfield
Comment 8 2021-10-31 23:03:08 PDT
Created attachment 442962 [details] WIP
Myles C. Maxfield
Comment 9 2021-10-31 23:21:18 PDT
Created attachment 442963 [details] WIP
Myles C. Maxfield
Comment 10 2021-10-31 23:25:22 PDT
Created attachment 442964 [details] WIP
Myles C. Maxfield
Comment 11 2021-11-01 01:22:37 PDT
Comment on attachment 442964 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=442964&action=review > Source/WebCore/Modules/WebGPU/GPUAdapter.h:40 > + static Ref<GPUAdapter> create(const String& name, Ref<GPUSupportedFeatures>&& features, Ref<GPUSupportedLimits>&& limits, bool isFallbackAdapter) String&& is probably better.
Myles C. Maxfield
Comment 12 2021-11-01 17:44:52 PDT
Created attachment 443043 [details] Patch
Myles C. Maxfield
Comment 13 2021-11-01 17:49:11 PDT
Created attachment 443044 [details] Patch
Alex Christensen
Comment 14 2021-11-02 09:31:59 PDT
Comment on attachment 443044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review > Source/WebCore/Modules/WebGPU/GPU.cpp:35 > + nit: extra space > Source/WebCore/Modules/WebGPU/GPUAdapter.cpp:35 > + ditto > Source/WebCore/bindings/scripts/CodeGenerator.pm:198 > - die "Processing document " . $useDocument->fileName . " did not generate anything."; > + # die "Processing document " . $useDocument->fileName . " did not generate anything."; Don't commit this.
Myles C. Maxfield
Comment 15 2021-11-03 22:59:51 PDT
Comment on attachment 443044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review > Source/WebCore/Modules/WebGPU/GPUDevice.h:54 > + const char* activeDOMObjectName() const final { return "GPUDevice"; } Private.
Myles C. Maxfield
Comment 16 2021-11-03 23:18:43 PDT
Comment on attachment 443044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review > Source/WebCore/Modules/WebGPU/GPUDevice.cpp:31 > +GPUDevice::~GPUDevice() = default
Myles C. Maxfield
Comment 17 2021-11-04 18:38:42 PDT
Created attachment 443367 [details] Patch for committing
Myles C. Maxfield
Comment 18 2021-11-06 13:50:57 PDT
Committed r285376 (243933@main): <https://commits.webkit.org/243933@main>
Radar WebKit Bug Importer
Comment 19 2021-11-06 13:51:18 PDT
<rdar://problem/85104354>
Note You need to log in before you can comment on or make changes to this bug.