Summary: | Upstream page/chromium/ | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> | ||||
Component: | Platform | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Darin Fisher (:fishd, Google)
2009-01-12 08:44:49 PST
Created attachment 26634 [details]
v1 patch
Comment on attachment 26634 [details]
v1 patch
Shouldn't ChromeClientChromium just be part of ChromeClient? It seems we should either move that one function to ChromeClient, or at least add a FIXME to do so (or a comment explaining why ChromeClientChromium should be separate).
Also ChromeClientChromium.h uses #ifndef ChromeClientWin
+ // FIXME: To match the macos behaviour we should return DragOperationNone
MacOS or mac os, but macos reads strange to me. :)
+bool DragController::isCopyKeyDown() {
{ on new line
Otherwise looks good. Sad that chrome doesn't support drag images. :(
I added a comment to ChromeClientChromium. That interface exists to hold things that are Chromium-specific. Right now, that only includes the popupOpened method, which is used to support the Chromium PopupMenu implementation. I don't think it makes sense to put that on ChromeClient since it isn't useful to other ports. |