Bug 232538

Summary:

[LFC][IFC] Add unicode-bidi control characters

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	koivisto: review+

Description zalan 2021-10-30 20:04:34 PDT

stub functions only.

Comment 1 zalan 2021-10-30 20:14:09 PDT

Created attachment 442925 [details]
Patch

Comment 2 Antti Koivisto 2021-10-30 22:46:03 PDT

Comment on attachment 442925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442925&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:220
>  void InlineItemsBuilder::handleInlineBox(const Box& inlineBox, EnterInlineBox enterInlineBox, InlineItems& inlineItems)

Maybe entering/exiting could be just two separate functions?

Comment 3 zalan 2021-10-31 06:41:39 PDT

Created attachment 442934 [details]
Patch

Comment 4 EWS 2021-10-31 07:25:51 PDT

Committed r285093 (243735@main): <https://commits.webkit.org/243735@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442934 [details].

Comment 5 Radar WebKit Bug Importer 2021-10-31 07:26:20 PDT

<rdar://problem/84856322>

Comment 6 Antti Koivisto 2021-10-31 23:00:01 PDT

Comment on attachment 442934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442934&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:260
> +    if (enteringContentControlChar)
> +        enterBidiContext(inlineBox, *enteringContentControlChar);
> +    if (nestedContentControlChar)
> +        enterBidiContext(inlineBox, *nestedContentControlChar);

I think these calls could be inside the switch, avoiding the variables.

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:302
> +    if (nestedContentControlChar)
> +        exitBidiContext(inlineBox, *nestedContentControlChar);
> +    if (exitingContentControlChar)
> +        exitBidiContext(inlineBox, *exitingContentControlChar);

Here too.