Bug 23252

Summary: need a flag to remove the selection rectangle in text controls
Product: WebKit Reporter: scroggo
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, caryclark, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
add a flag to remove the selection rectangle in text controls
none
add a flag to remove the selection rectangle in text controls adele: review-

scroggo
Reported 2009-01-12 07:48:09 PST
On the android platform, we draw our own renderer on top of a focused RenderTextControl. Just like with ENABLE_TEXT_CARET, we want to remove the drawing of the selection rectangle in a RenderTextControl. This is important because we are multithreaded, and our webkit thread lags behind, so when we remove our renderer, the selection (if any), which is no longer valid, shows up.
Attachments
add a flag to remove the selection rectangle in text controls (3.39 KB, patch)
2009-01-12 07:52 PST, scroggo 		no flags
DetailsFormatted DiffDiff
add a flag to remove the selection rectangle in text controls (3.49 KB, patch)
2009-01-12 08:24 PST, scroggo 		adele: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
scroggo
Comment 1 2009-01-12 07:52:08 PST
Created attachment 26631 [details] add a flag to remove the selection rectangle in text controls
scroggo
Comment 2 2009-01-12 08:24:30 PST
Created attachment 26632 [details] add a flag to remove the selection rectangle in text controls added email address to changelog
Mark Rowe (bdash)
Comment 3 2009-01-12 23:41:49 PST
Do we really need independent defines for every UI quirk that Android has?
Adele Peterson
Comment 4 2009-03-23 11:51:58 PDT
Comment on attachment 26632 [details] add a flag to remove the selection rectangle in text controls I agree with Mark. Its unnecessary to have all these #defines. One way to do this would be to cause the selection color to be clear in methods like platformActiveSelectionBackgroundColor. Or you could have RenderTheme/some other platform class provide a way to tell if selection is supported on a particular platform, and you could ask that method before drawing selection.
Ahmad Saleem
Comment 5 2022-09-20 05:55:40 PDT
ap@webkit.org - It was for Android, do we need this anymore? Thanks!
Ryosuke Niwa
Comment 6 2022-09-20 21:29:32 PDT
We're not gonna support Android at this point.
Note You need to log in before you can comment on or make changes to this bug.