Bug 232516
| Summary: | [GTK] Remove on-demand hardware acceleration setting | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | alicem, bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=125526 https://bugs.webkit.org/show_bug.cgi?id=244835 |
||
| Bug Depends on: | |||
| Bug Blocks: | 210100 | ||
Michael Catanzaro
I understand that GTK 4 port requires always-on accelerated compositing mode. Is this correct?
If so, we should remove the setting from public API.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
I was planning to remove WebKitHardwareAccelerationPolicy and associated functions altogether. I see Carlos has suggested in bug #125526 that we should maybe not do that after all. Not sure what to do now. Remove only the on demand policy?
Michael Catanzaro
Hi Carlos Garcia, hi Alexander, can you discuss and provide a clear answer as to whether we'll still have hardware acceleration policy in the new API version? Alexander was saying as recently as a couple days ago that hardware acceleration is mandatory with GTK 4, but this is contradicted by Carlos's comment in bug #125526. Which is true?
I understand WEBKIT_HARDWARE_ACCELERATION_POLICY_ON_DEMAND goes away no matter what. The question is whether to continue to provide WEBKIT_HARDWARE_ACCELERATION_POLICY_NEVER or not.
Alice Mikhaylenko
I mean as far as I know nonaccelerated doesn't work with GTK4 at least right now? Certainly I wasn't able to switch to it in minibrowser at least a while ago.
Michael Catanzaro
Talked to Carlos. Sounds like it *could* work but doesn't. I will plan to remove the API. If somebody implements it, then we can restore the API.
Michael Catanzaro
Implemented in bug #244835. So we should only remove the on-demand policy, not the entire API.
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/9398
EWS
Committed 259686@main (7e5444b964e5): <https://commits.webkit.org/259686@main>
Reviewed commits have been landed. Closing PR #9398 and removing active labels.