Increase responsiveness timeout for network process

• Component: New Bugs
• Status: RESOLVED FIXED

[Sihui Liu]

...

[Sihui Liu]

Created attachment 442864 [details]
Patch

[Chris Dumez]

Comment on attachment 442864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442864&action=review

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:47
> +    AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority, Seconds);

Why are you adding a second constructor instead of extending the existing one?

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:204
> +    : AuxiliaryProcessProxy(anyProcessPoolAlwaysRunsAtBackgroundPriority(), 6_s)

Please use a global static constant with a nice name for 6_s.

[Sihui Liu]

Created attachment 442870 [details]
Patch

[Sihui Liu]

To help resolve web process crash issue rdar://84745326.

[Sihui Liu]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 442864 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442864&action=review
> 
> > Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:47
> > +    AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority, Seconds);
> 
> Why are you adding a second constructor instead of extending the existing
> one?

Removed.

> 
> > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:204
> > +    : AuxiliaryProcessProxy(anyProcessPoolAlwaysRunsAtBackgroundPriority(), 6_s)
> 
> Please use a global static constant with a nice name for 6_s.

Sure.

[Chris Dumez]

Comment on attachment 442870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442870&action=review

r=me assuming the bots are happy

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:89
> +static const Seconds networkProcessResponsivenessTimeout = 6_s;

constexpr

[Sihui Liu]

Created attachment 442987 [details]
Patch for landing

[EWS]

Committed r285115 (243756@main): <https://commits.webkit.org/243756@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442987 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84888098>