Bug 232487

Summary:

[LFC][IFC] Introduce InlineItemsBuilder

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2021-10-29 08:47:59 PDT

this is going to be used for building bidi compatible inline items.

Comment 1 zalan 2021-10-29 08:50:48 PDT

Created attachment 442822 [details]
Patch

Comment 2 Antti Koivisto 2021-10-29 08:54:15 PDT

Comment on attachment 442822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442822&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:34
> +InlineItemsBuilder::InlineItemsBuilder(const ContainerBox& formattingContextRoot, InlineFormattingState& formattingState)

Finally!

Comment 3 zalan 2021-10-29 09:43:42 PDT

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 442822 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442822&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:34
> > +InlineItemsBuilder::InlineItemsBuilder(const ContainerBox& formattingContextRoot, InlineFormattingState& formattingState)
> 
> Finally!
🎆

Comment 4 zalan 2021-10-29 09:52:21 PDT

Created attachment 442826 [details]
Patch

Comment 5 EWS 2021-10-29 14:09:18 PDT

Committed r285050 (243693@main): <https://commits.webkit.org/243693@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442826 [details].

Comment 6 Radar WebKit Bug Importer 2021-10-29 14:10:23 PDT

<rdar://problem/84823069>