RESOLVED FIXED 232487
[LFC][IFC] Introduce InlineItemsBuilder 
https://bugs.webkit.org/show_bug.cgi?id=232487
Summary [LFC][IFC] Introduce InlineItemsBuilder
alan
Reported 2021-10-29 08:47:59 PDT
this is going to be used for building bidi compatible inline items.
Attachments
Patch (16.90 KB, patch)
2021-10-29 08:50 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (16.88 KB, patch)
2021-10-29 09:52 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-10-29 08:50:48 PDT
Created attachment 442822 [details] Patch
Antti Koivisto
Comment 2 2021-10-29 08:54:15 PDT
Comment on attachment 442822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442822&action=review > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:34 > +InlineItemsBuilder::InlineItemsBuilder(const ContainerBox& formattingContextRoot, InlineFormattingState& formattingState) Finally!
alan
Comment 3 2021-10-29 09:43:42 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 442822 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442822&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:34 > > +InlineItemsBuilder::InlineItemsBuilder(const ContainerBox& formattingContextRoot, InlineFormattingState& formattingState) > > Finally! 🎆
alan
Comment 4 2021-10-29 09:52:21 PDT
Created attachment 442826 [details] Patch
EWS
Comment 5 2021-10-29 14:09:18 PDT
Committed r285050 (243693@main): <https://commits.webkit.org/243693@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442826 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-29 14:10:23 PDT
<rdar://problem/84823069>
Note You need to log in before you can comment on or make changes to this bug.