Bug 232487 - [LFC][IFC] Introduce InlineItemsBuilder
Summary: [LFC][IFC] Introduce InlineItemsBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-29 08:47 PDT by zalan
Modified: 2021-10-29 14:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.90 KB, patch)
2021-10-29 08:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (16.88 KB, patch)
2021-10-29 09:52 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-10-29 08:47:59 PDT 
this is going to be used for building bidi compatible inline items.
Comment 1 zalan 2021-10-29 08:50:48 PDT 
Created attachment 442822 [details]
Patch
Comment 2 Antti Koivisto 2021-10-29 08:54:15 PDT 
Comment on attachment 442822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442822&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:34
> +InlineItemsBuilder::InlineItemsBuilder(const ContainerBox& formattingContextRoot, InlineFormattingState& formattingState)

Finally!
Comment 3 zalan 2021-10-29 09:43:42 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 442822 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442822&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:34
> > +InlineItemsBuilder::InlineItemsBuilder(const ContainerBox& formattingContextRoot, InlineFormattingState& formattingState)
> 
> Finally!
🎆
Comment 4 zalan 2021-10-29 09:52:21 PDT 
Created attachment 442826 [details]
Patch
Comment 5 EWS 2021-10-29 14:09:18 PDT 
Committed r285050 (243693@main): <https://commits.webkit.org/243693@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442826 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-29 14:10:23 PDT 
<rdar://problem/84823069>