Bug 232454

Summary:

AVDelegatingPlaybackCoordinator error compiling on macOS 11

Product:

WebKit

Reporter:

Darryl Pogue <dvpdiner2>

Component:

New Bugs

Assignee:

Brady Eidson <beidson>

Status:

REOPENED

Severity:

Normal

CC:

beidson, benjamin, cdumez, cmarcelo, commit-queue, ews-watchlist, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Mac (Intel)

OS:

macOS 11

Bug Depends on:

233762

Bug Blocks:

Attachments:

Description	Flags
Build log showing error	none
Patch	thorton: review+
PFL	none

Darryl Pogue

Reported 2021-10-28 13:29:03 PDT

Created attachment 442736 [details] Build log showing error Compiling at ToT: https://commits.webkit.org/243641@main Running Tools/Scripts/build-webkit on macOS 11.6.1 with Xcode 13.1, getting a compiler error: 'AVDelegatingPlaybackCoordinator' is only available on macOS 12.0 or newer Build log attached.

Attachments
Build log showing error (2.85 MB, text/plain) 2021-10-28 13:29 PDT, Darryl Pogue	no flags	Details
Patch (2.84 KB, patch) 2021-12-01 22:47 PST, Brady Eidson	thorton: review+	Details Formatted Diff Diff
PFL (2.84 KB, patch) 2021-12-02 00:02 PST, Brady Eidson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darryl Pogue

Comment 1 2021-10-29 10:23:06 PDT

*** This bug has been marked as a duplicate of bug 226235 ***

Brady Eidson

Comment 2 2021-12-01 22:46:57 PST

This is not a dupe of that other bug...

Brady Eidson

Comment 3 2021-12-01 22:47:14 PST

Created attachment 445672 [details] Patch

Tim Horton

Comment 4 2021-12-01 23:29:33 PST

Comment on attachment 445672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445672&action=review > Source/WTF/wtf/PlatformHave.h:1100 > +#define HAVE_DELEGATING_PLAYBACK_COORDINATOR 1 I would go with HAVE_AV_DELEGATING_PLAYBACK_COORDINATOR. Also you don't need review for this kind of stuff > Source/WebCore/PAL/ChangeLog:8 > + * pal/cocoa/AVFoundationSoftLink.h: Don't softlink on platforms that don't have it Weird? What about AT LEAST the SOFT_LINK_CLASS_FOR_SOURCE?

Tim Horton

Comment 5 2021-12-01 23:29:48 PST

Brady Eidson

Comment 6 2021-12-02 00:02:15 PST

Created attachment 445683 [details] PFL

Brady Eidson

Comment 7 2021-12-02 00:03:20 PST

(In reply to Tim Horton from comment #4) > Comment on attachment 445672 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445672&action=review > > > Source/WTF/wtf/PlatformHave.h:1100 > > +#define HAVE_DELEGATING_PLAYBACK_COORDINATOR 1 > > I would go with HAVE_AV_DELEGATING_PLAYBACK_COORDINATOR. Also you don't need > review for this kind of stuff > > > Source/WebCore/PAL/ChangeLog:8 > > + * pal/cocoa/AVFoundationSoftLink.h: Don't softlink on platforms that don't have it > > Weird? What about AT LEAST the SOFT_LINK_CLASS_FOR_SOURCE? Because of the weird shenanigans in play causing the error... HEADER is all that's needed?

Tim Horton

Comment 8 2021-12-02 00:10:51 PST

Comment on attachment 445683 [details] PFL View in context: https://bugs.webkit.org/attachment.cgi?id=445683&action=review > Source/WTF/wtf/PlatformHave.h:1104 > +#if PLATFORM(COCOA) > +#define HAVE_AV_DELEGATING_PLAYBACK_COORDINATOR 1 > +#endif > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 120000 > +#undef HAVE_AV_DELEGATING_PLAYBACK_COORDINATOR > +#endif Also why is this not all just one condition?

EWS

Comment 9 2021-12-02 01:02:34 PST

Committed r286420 (244766@main): <https://commits.webkit.org/244766@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445683 [details].

Radar WebKit Bug Importer

Comment 10 2021-12-02 01:03:27 PST

<rdar://problem/85960239>

WebKit Commit Bot

Comment 11 2021-12-02 08:32:41 PST

Re-opened since this is blocked by bug 233762

Note You need to log in before you can comment on or make changes to this bug.