Bug 232443

Summary: [webkitscmpy] Fix commits set on branch
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2021-10-28 10:27:48 PDT
When we are grabbing a set of commits on a branch, the current code returns incorrect identifiers for those commits in git.
Attachments
Patch (2.45 KB, patch)
2021-10-28 10:32 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.08 KB, patch)
2021-10-28 12:38 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.03 KB, patch)
2021-10-28 13:30 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-28 10:28:02 PDT
<rdar://problem/84763432>
Jonathan Bedard
Comment 2 2021-10-28 10:32:22 PDT
Created attachment 442717 [details] Patch
Darin Adler
Comment 3 2021-10-28 12:06:28 PDT
Comment on attachment 442717 [details] Patch Do we have a way to test this?
Jonathan Bedard
Comment 4 2021-10-28 12:20:04 PDT
Pull-request: https://github.com/WebKit/WebKit/pull/26
Jonathan Bedard
Comment 5 2021-10-28 12:36:55 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 442717 [details] > Patch > > Do we have a way to test this? Went back to double-check, and yes. Our existing tests almost caught it in the first place (they needed 3 commits on a branch instead of 2)
Jonathan Bedard
Comment 6 2021-10-28 12:38:17 PDT
Created attachment 442731 [details] Patch
Jonathan Bedard
Comment 7 2021-10-28 13:30:00 PDT
Created attachment 442737 [details] Patch
EWS
Comment 8 2021-10-28 14:04:45 PDT
Committed r285002 (243648@main): <https://commits.webkit.org/243648@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442737 [details].
Note You need to log in before you can comment on or make changes to this bug.