Bug 232438

Summary: Add stubs for the Web Locks API
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, benjamin, calvaris, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, sihui_liu, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232436    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-10-28 09:38:52 PDT
Add stubs for the Web Locks API: - https://wicg.github.io/web-locks/#api
Attachments
Patch (126.46 KB, patch)
2021-10-28 09:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (131.98 KB, patch)
2021-10-28 13:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (132.96 KB, patch)
2021-10-28 15:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-10-28 09:40:44 PDT
Created attachment 442711 [details] Patch
Chris Dumez
Comment 2 2021-10-28 13:55:00 PDT
Created attachment 442740 [details] Patch
Chris Dumez
Comment 3 2021-10-28 15:31:08 PDT
Created attachment 442752 [details] Patch
Geoffrey Garen
Comment 4 2021-10-28 17:03:47 PDT
Comment on attachment 442752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442752&action=review r=me > Source/WebCore/Modules/web-locks/NavigatorLocks.idl:27 > + SecureContext This seems like an arbitrary restriction, but I imagine it's required by the spec?
Chris Dumez
Comment 5 2021-10-28 17:31:09 PDT
Comment on attachment 442752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442752&action=review >> Source/WebCore/Modules/web-locks/NavigatorLocks.idl:27 >> + SecureContext > > This seems like an arbitrary restriction, but I imagine it's required by the spec? Yes, this is per spec. A lot of the new APIs are only exposed to secure contexts.
EWS
Comment 6 2021-10-28 18:04:49 PDT
Committed r285012 (243658@main): <https://commits.webkit.org/243658@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442752 [details].
Radar WebKit Bug Importer
Comment 7 2021-10-28 18:05:28 PDT
<rdar://problem/84787791>
Note You need to log in before you can comment on or make changes to this bug.