Bug 232438

Summary: Add stubs for the Web Locks API
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, benjamin, calvaris, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, sihui_liu, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232436    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2021-10-28 09:38:52 PDT
Add stubs for the Web Locks API:
- https://wicg.github.io/web-locks/#api
Comment 1 Chris Dumez 2021-10-28 09:40:44 PDT
Created attachment 442711 [details]
Patch
Comment 2 Chris Dumez 2021-10-28 13:55:00 PDT
Created attachment 442740 [details]
Patch
Comment 3 Chris Dumez 2021-10-28 15:31:08 PDT
Created attachment 442752 [details]
Patch
Comment 4 Geoffrey Garen 2021-10-28 17:03:47 PDT
Comment on attachment 442752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442752&action=review

r=me

> Source/WebCore/Modules/web-locks/NavigatorLocks.idl:27
> +    SecureContext

This seems like an arbitrary restriction, but I imagine it's required by the spec?
Comment 5 Chris Dumez 2021-10-28 17:31:09 PDT
Comment on attachment 442752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442752&action=review

>> Source/WebCore/Modules/web-locks/NavigatorLocks.idl:27
>> +    SecureContext
> 
> This seems like an arbitrary restriction, but I imagine it's required by the spec?

Yes, this is per spec. A lot of the new APIs are only exposed to secure contexts.
Comment 6 EWS 2021-10-28 18:04:49 PDT
Committed r285012 (243658@main): <https://commits.webkit.org/243658@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442752 [details].
Comment 7 Radar WebKit Bug Importer 2021-10-28 18:05:28 PDT
<rdar://problem/84787791>