Bug 232415

Summary: Isolated tree mode: Dispatch all calls to [WebAccessibilityObjectWrapper accessibilityAttributeValue] in WTR::AccessibilityUIElement to the AX thread.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2021-10-27 19:19:43 PDT
Isolated tree mode: Dispatch all calls to [WebAccessibilityObjectWrapper accessibilityAttributeValue] in WTR::AccessibilityUIElement to the AX thread.
Attachments
Patch (48.30 KB, patch)
2021-10-27 19:29 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (53.46 KB, patch)
2021-10-28 07:35 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (53.46 KB, patch)
2021-10-28 07:42 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-27 19:19:55 PDT
<rdar://problem/84738483>
Andres Gonzalez
Comment 2 2021-10-27 19:29:29 PDT
Created attachment 442665 [details] Patch
chris fleizach
Comment 3 2021-10-27 20:51:31 PDT
Comment on attachment 442665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442665&action=review > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:341 > + return ::WTR::attributeValue(m_element.get(), attributeName); do we need the preceding colons? ::WTR > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:787 > + id description = descriptionOfValue(attributeValue(@"AXLanguage"), m_element.get()); do you want to make descriptionOfValue also take only one argument, and handle m_element inside of it?
Andres Gonzalez
Comment 4 2021-10-28 07:35:56 PDT
Created attachment 442705 [details] Patch
Andres Gonzalez
Comment 5 2021-10-28 07:42:23 PDT
Created attachment 442706 [details] Patch
Andres Gonzalez
Comment 6 2021-10-28 07:46:28 PDT
(In reply to chris fleizach from comment #3) > Comment on attachment 442665 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442665&action=review > > > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:341 > > + return ::WTR::attributeValue(m_element.get(), attributeName); > > do we need the preceding colons? ::WTR Nope, removed it. When trying to put it in the header as an inline, the compiler was complaining about it, but ended up moving it to the .mm and now the compiler is fine without the ::. > > > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:787 > > + id description = descriptionOfValue(attributeValue(@"AXLanguage"), m_element.get()); > > do you want to make descriptionOfValue also take only one argument, and > handle m_element inside of it? Done.
EWS
Comment 7 2021-10-28 13:34:18 PDT
Committed r284998 (243644@main): <https://commits.webkit.org/243644@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442706 [details].
Note You need to log in before you can comment on or make changes to this bug.