Bug 232415

Summary:

Isolated tree mode: Dispatch all calls to [WebAccessibilityObjectWrapper accessibilityAttributeValue] in WTR::AccessibilityUIElement to the AX thread.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Andres Gonzalez 2021-10-27 19:19:43 PDT

Isolated tree mode: Dispatch all calls to [WebAccessibilityObjectWrapper accessibilityAttributeValue] in WTR::AccessibilityUIElement to the AX thread.

Comment 1 Radar WebKit Bug Importer 2021-10-27 19:19:55 PDT

<rdar://problem/84738483>

Comment 2 Andres Gonzalez 2021-10-27 19:29:29 PDT

Created attachment 442665 [details]
Patch

Comment 3 chris fleizach 2021-10-27 20:51:31 PDT

Comment on attachment 442665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442665&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:341
> +    return ::WTR::attributeValue(m_element.get(), attributeName);

do we need the preceding colons? ::WTR

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:787
> +    id description = descriptionOfValue(attributeValue(@"AXLanguage"), m_element.get());

do you want to make descriptionOfValue also take only one argument, and handle m_element inside of it?

Comment 4 Andres Gonzalez 2021-10-28 07:35:56 PDT

Created attachment 442705 [details]
Patch

Comment 5 Andres Gonzalez 2021-10-28 07:42:23 PDT

Created attachment 442706 [details]
Patch

Comment 6 Andres Gonzalez 2021-10-28 07:46:28 PDT

(In reply to chris fleizach from comment #3)
> Comment on attachment 442665 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442665&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:341
> > +    return ::WTR::attributeValue(m_element.get(), attributeName);
> 
> do we need the preceding colons? ::WTR

Nope, removed it. When trying to put it in the header as an inline, the compiler was complaining about it, but ended up moving it to the .mm and now the compiler is fine without the ::.

> 
> > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:787
> > +    id description = descriptionOfValue(attributeValue(@"AXLanguage"), m_element.get());
> 
> do you want to make descriptionOfValue also take only one argument, and
> handle m_element inside of it?

Done.

Comment 7 EWS 2021-10-28 13:34:18 PDT

Committed r284998 (243644@main): <https://commits.webkit.org/243644@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442706 [details].