Bug 232415 - Isolated tree mode: Dispatch all calls to [WebAccessibilityObjectWrapper accessibilityAttributeValue] in WTR::AccessibilityUIElement to the AX thread.
Summary: Isolated tree mode: Dispatch all calls to [WebAccessibilityObjectWrapper acce...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-27 19:19 PDT by Andres Gonzalez
Modified: 2021-10-28 13:34 PDT (History)
10 users (show)

See Also:

Attachments
Patch (48.30 KB, patch)
2021-10-27 19:29 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (53.46 KB, patch)
2021-10-28 07:35 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (53.46 KB, patch)
2021-10-28 07:42 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2021-10-27 19:19:43 PDT 
Isolated tree mode: Dispatch all calls to [WebAccessibilityObjectWrapper accessibilityAttributeValue] in WTR::AccessibilityUIElement to the AX thread.
Comment 1 Radar WebKit Bug Importer 2021-10-27 19:19:55 PDT 
<rdar://problem/84738483>
Comment 2 Andres Gonzalez 2021-10-27 19:29:29 PDT 
Created attachment 442665 [details]
Patch
Comment 3 chris fleizach 2021-10-27 20:51:31 PDT 
Comment on attachment 442665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442665&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:341
> +    return ::WTR::attributeValue(m_element.get(), attributeName);

do we need the preceding colons? ::WTR

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:787
> +    id description = descriptionOfValue(attributeValue(@"AXLanguage"), m_element.get());

do you want to make descriptionOfValue also take only one argument, and handle m_element inside of it?
Comment 4 Andres Gonzalez 2021-10-28 07:35:56 PDT 
Created attachment 442705 [details]
Patch
Comment 5 Andres Gonzalez 2021-10-28 07:42:23 PDT 
Created attachment 442706 [details]
Patch
Comment 6 Andres Gonzalez 2021-10-28 07:46:28 PDT 
(In reply to chris fleizach from comment #3)
> Comment on attachment 442665 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442665&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:341
> > +    return ::WTR::attributeValue(m_element.get(), attributeName);
> 
> do we need the preceding colons? ::WTR

Nope, removed it. When trying to put it in the header as an inline, the compiler was complaining about it, but ended up moving it to the .mm and now the compiler is fine without the ::.

> 
> > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:787
> > +    id description = descriptionOfValue(attributeValue(@"AXLanguage"), m_element.get());
> 
> do you want to make descriptionOfValue also take only one argument, and
> handle m_element inside of it?

Done.
Comment 7 EWS 2021-10-28 13:34:18 PDT 
Committed r284998 (243644@main): <https://commits.webkit.org/243644@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442706 [details].